Skip to content

Commit af4ab8b

Browse files
author
Krishna Govind
committed
Revert "Move tab_list_ui/ code into its own DFM"
This reverts commit c0b9245. Reason for revert: breaks build, bug 941226 Original change's description: > Move tab_list_ui/ code into its own DFM > > BUG=925126 > > (cherry picked from commit 02d5848947400d769890ab3bfdf8eb66cd731c4e) > > Change-Id: I7e0f676f4e9e332945d70bedcbcb6f84665a3c80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475881 > Reviewed-by: Tommy Nyquist <[email protected]> > Reviewed-by: Ilya Sherman <[email protected]> > Reviewed-by: Ted Choc <[email protected]> > Reviewed-by: Theresa <[email protected]> > Reviewed-by: Tibor Goldschwendt <[email protected]> > Commit-Queue: Yusuf Ozuysal <[email protected]> > Cr-Original-Commit-Position: refs/heads/master@{#639609} > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519092 > Reviewed-by: Yusuf Ozuysal <[email protected]> > Cr-Commit-Position: refs/branch-heads/3729@{#62} > Cr-Branched-From: d4a8972-refs/heads/master@{#638880} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] Change-Id: I473f8fca0da5bc3276d4ffbed466e8357d0a8bc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 925126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519451 Reviewed-by: Krishna Govind <[email protected]> Cr-Commit-Position: refs/branch-heads/3729@{#71} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
1 parent 4bc7b1c commit af4ab8b

File tree

53 files changed

+214
-498
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+214
-498
lines changed

chrome/android/BUILD.gn

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ import("//build/config/python.gni")
99
import("//build/util/process_version.gni")
1010
import("//chrome/android/chrome_common_shared_library.gni")
1111
import("//chrome/android/chrome_public_apk_tmpl.gni")
12-
import("//chrome/android/features/tab_ui/tab_management_java_sources.gni")
13-
import("//chrome/android/features/tab_ui/tab_ui_module_tmpl.gni")
1412
import("//chrome/android/features/vr/public_vr_java_sources.gni")
1513
import("//chrome/android/feed/feed_java_sources.gni")
1614
import("//chrome/android/monochrome_android_manifest_jinja_variables.gni")
@@ -422,9 +420,6 @@ android_library("chrome_java") {
422420

423421
java_files += public_vr_java_sources
424422

425-
# Include sources from public_tab_management_java_sources.gni.
426-
java_files += public_tab_management_java_sources
427-
428423
if (enable_vr) {
429424
deps += [
430425
":chrome_vr_java_resources",
@@ -590,7 +585,6 @@ junit_binary("chrome_junit_tests") {
590585
"//base:base_java",
591586
"//base:base_java_test_support",
592587
"//base:base_junit_test_support",
593-
"//chrome/android/features/tab_ui:java",
594588
"//chrome/android/webapk/libs/client:client_java",
595589
"//chrome/android/webapk/libs/common:common_java",
596590
"//chrome/android/webapk/test:junit_test_support",
@@ -693,7 +687,6 @@ android_library("chrome_test_java") {
693687
"//base:base_java_test_support",
694688
"//chrome/android:app_hooks_java",
695689
"//chrome/android:chrome_java",
696-
"//chrome/android/features/tab_ui:java",
697690
"//chrome/android/third_party/compositor_animator:compositor_animator_java",
698691
"//chrome/android/webapk/libs/client:client_java",
699692
"//chrome/android/webapk/libs/common:common_java",
@@ -2040,19 +2033,6 @@ template("monochrome_public_bundle_tmpl") {
20402033
}
20412034
}
20422035

2043-
tab_ui_module_tmpl("${target_name}__tab_ui_bundle_module") {
2044-
manifest_package = manifest_package
2045-
module_name = "TabUiMonochromePublic"
2046-
base_module_target = ":$_base_module_target_name"
2047-
if (_is_trichrome) {
2048-
version_code = trichrome_version_code
2049-
} else {
2050-
version_code = monochrome_version_code
2051-
}
2052-
version_name = chrome_version_name
2053-
uncompress_shared_libraries = true
2054-
}
2055-
20562036
android_app_bundle(target_name) {
20572037
if (_is_trichrome) {
20582038
add_native_lib_placeholders_for_base_module = true
@@ -2069,7 +2049,7 @@ template("monochrome_public_bundle_tmpl") {
20692049

20702050
extra_modules = []
20712051
if (modularize_ar) {
2072-
extra_modules += [
2052+
extra_modules = [
20732053
{
20742054
name = "ar"
20752055
module_target = ":${target_name}__ar_bundle_module"
@@ -2084,12 +2064,6 @@ template("monochrome_public_bundle_tmpl") {
20842064
},
20852065
]
20862066
}
2087-
extra_modules += [
2088-
{
2089-
name = "tab_ui"
2090-
module_target = ":${target_name}__tab_ui_bundle_module"
2091-
},
2092-
]
20932067
}
20942068
}
20952069

chrome/android/features/module_names_to_package_ids.gni

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,4 @@
22
resource_packages_id_mapping = [
33
"ar=0x7e",
44
"vr=0x7d",
5-
"tab_ui=0x7c",
65
]

chrome/android/features/tab_ui/AndroidManifest.xml

Lines changed: 0 additions & 21 deletions
This file was deleted.

chrome/android/features/tab_ui/BUILD.gn

Lines changed: 0 additions & 58 deletions
This file was deleted.

chrome/android/features/tab_ui/java/DEPS

Lines changed: 0 additions & 6 deletions
This file was deleted.

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/GridTabSwitcher.java

Lines changed: 0 additions & 12 deletions
This file was deleted.

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/SilenceLintErrors.java

Lines changed: 0 additions & 31 deletions
This file was deleted.

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupUi.java

Lines changed: 0 additions & 15 deletions
This file was deleted.

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabManagementModule.java

Lines changed: 0 additions & 17 deletions
This file was deleted.

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabManagementModuleImpl.java

Lines changed: 0 additions & 29 deletions
This file was deleted.

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabManagementModuleProvider.java

Lines changed: 0 additions & 35 deletions
This file was deleted.

chrome/android/features/tab_ui/tab_management_java_sources.gni

Lines changed: 0 additions & 22 deletions
This file was deleted.

chrome/android/features/tab_ui/tab_ui_module_tmpl.gni

Lines changed: 0 additions & 40 deletions
This file was deleted.

chrome/android/java/res/layout/bottom_tab_grid_toolbar.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Use of this source code is governed by a BSD-style license that can be
44
found in the LICENSE file. -->
55

6-
<org.chromium.chrome.browser.tasks.tab_management.TabGroupUiToolbarView
6+
<org.chromium.chrome.browser.tasks.tab_list_ui.BottomTabListToolbarView
77
xmlns:android="http://schemas.android.com/apk/res/android"
88
xmlns:app="http://schemas.android.com/apk/res-auto"
99
android:layout_width="match_parent"
@@ -37,4 +37,4 @@
3737
app:tint="@color/standard_mode_tint"
3838
android:contentDescription="@string/bottom_tab_grid_new_tab" />
3939
</LinearLayout>
40-
</org.chromium.chrome.browser.tasks.tab_management.TabGroupUiToolbarView>
40+
</org.chromium.chrome.browser.tasks.tab_list_ui.BottomTabListToolbarView>

0 commit comments

Comments
 (0)