[Sync] No-op RecordUserEvent is ModelTypeStore has not initialized.

If RecordUserEvent happened before the ModelTypeStore initialized,
we would deref null and cause a crash. The other usages of store_
are driven by sync, which shouldn't call into us until we tell sync
that we're ready, so they should not need an null check. This fix is
ultimately a hack, and can be removed once crbug.com/709094 is done.

[email protected]

(cherry picked from commit 2aa9702)

Bug: 748384
Change-Id: Iafeffee0d9bb77b5d539b72992b085d1833015ee
Reviewed-on: https://chromium-review.googlesource.com/584554
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#489385}
Reviewed-on: https://chromium-review.googlesource.com/587830
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3163@{#68}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

Author: Sky Malice

components/sync/user_events/user_event_sync_bridge.cc

@@ -123,6 +123,11 @@ void UserEventSyncBridge::DisableSync() {
 
 void UserEventSyncBridge::RecordUserEvent(
     std::unique_ptr<UserEventSpecifics> specifics) {
+  // TODO(skym): Remove this when ModelTypeStore synchronously returns a
+  // partially initialized reference, see crbug.com/709094.
+  if (!store_) {
+    return;
+  }
   std::string storage_key = GetStorageKeyFromSpecifics(*specifics);
   std::unique_ptr<WriteBatch> batch = store_->CreateWriteBatch();
   batch->WriteData(storage_key, specifics->SerializeAsString());