You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reland "Cleanup lifetime handling in P2P sockets."
This is a reland of e6df634
Original change's description:
> Cleanup lifetime handling in P2P sockets.
>
> Several fixes for P2P sockets:
> 1. P2PSocketTcpBase no longer posts tasks with base::Unretained().
> 2. Previously P2P sockets were destroyed only in response to Mojo
> interfaces errors. They were not destroyed on other error. Fixed
> it now.
> 3. Simplified TCP server socket protocol. Now the accepted socket is
> passed directly in IncomingTcpConnection.
> 4. Updated unittests to verify that P2P sockets are destroyed in
> response to errors.
> 5. Other minor cleanups, particularly moved packet dump logic to
> SocketManager and removed some unittests that are not relevant
> after migration to mojo.
>
> Bug: 877515, 877514
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I55276e372185c558667289a1efdfcf0421c3d7bc
> Reviewed-on: https://chromium-review.googlesource.com/1189083
> Reviewed-by: Nasko Oskov <[email protected]>
> Reviewed-by: John Abd-El-Malek <[email protected]>
> Commit-Queue: Sergey Ulanov <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#588430}
[email protected],[email protected]
Bug: 877515, 877514,880218
Change-Id: I0cc79616b70f7900e6c551a7c91e404de2fb7dd3
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1206338
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Sergey Ulanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#588887}(cherry picked from commit e07f397)
Reviewed-on: https://chromium-review.googlesource.com/1207091
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/3538@{#51}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
0 commit comments