Skip to content

rawToProxy WeakMap.set is never called #56

Open
@NesCafe62

Description

@NesCafe62

was reading through the code to see how observable is implemented with proxies. I saw this line https://github.com/nx-js/observer-util/blob/master/src/handlers.js#L28 and thought rawToProxy should work as a cache to avoid recreating proxy if some nested property is accessed multiple times. but after search by rawToProxy I could not find any set call.

I understand that it only affects perfomance but not affect the correcntess of behavior

edit: seems same is for proxyToRaw

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions