Stencil: Upgrade dependencies with NX leads to -> (0 , buildable_libs_utils_1.checkDependentProjectsHaveBeenBuilt) is not a function

[andberg]

Describe the bug
As I upgraded our teams project I now am struggling with an issue while serving the library.

NX   (0 , buildable_libs_utils_1.checkDependentProjectsHaveBeenBuilt) is not a function
TypeError: (0 , buildable_libs_utils_1.checkDependentProjectsHaveBeenBuilt) is not a function
    at runExecutor_1 

Seems to be similar to this one #1176 with regards to that the naming has changed.

@nxext/stencil/src/executors/serve/executor.js is calling checkDependentProjectsHaveBeenBuilt from @nx/js/src/utils/buildable-libs-utils, but there is no function there with that name. It now seems to now be called calculateProjectBuildableDependencies (I'm guessing).

To Reproduce
Steps to reproduce the behavior:

• Branch of our project that with this change https://gitlab.com/arbetsformedlingen/designsystem/digi/-/merge_requests/1304
• npm i
• npm run af (starts a serve-command for our Stencil-components)

Expected behavior
Since I have upgraded to NX 20.x.x and if I read your documentation correctly you also have NX 20.x.x and it should work as expected.
Or have I missed something? Am a bit new to managing such a large Monorepo 🙈

[jpthedev]

We too facing the exact same issue in our project (using Nx monorepo with stencil js as design system and React, Angular are the consuming apps), when we tried to upgrade the Nx, it was running in @nrwl - version 15.4.4 after it is upgraded to @nx version 20.0.0, we updated all its dependencies. And while starting the local serve or build facing the same issue - NX (0 , buildable_libs_utils_1.checkDependentProjectsHaveBeenBuilt) is not a function. Am i missing anything, do i need to add anything in typescript config or babel rc, please let me know. Thanks in advance.
@DominikPieper @kristianmandrup @dgonzalezr @marckassay

[MotassemJa]

Same here..

[sonalnaik2906]

Facing exact same issue. I did upgrade NX to 20. upgraded stencil as well.
When i am trying to build my stencil project, its throwing below error.

Nx Report:

[dgonzalezr]

Hey guys, I got hit by the same error after updating our project NX dependencies. It seems that some changes removed the method used by @nxext/stencil from NX.

I'm my case, it's only affecting when I'm running stencil serve for local development, not when building it (stencil build).

I'm looking at what the implications are. I'm not a maintainer of this repo, but trying to do my best to fix some known and personal issues that I face from time to time, so I'm kindly asking for a bit of patience 😉 . cc. @DominikPieper

[andberg]

@dgonzalezr I've been pre-occupied a bit, but are starting to look at this again. Have you started PR with this change? Can I help or help with testing it?
I'm debating if I should see if I can make a PR to make this work, or just try to work around the nx-extension and try to go with Stencils own.

[DrewLandgraveCbsi]

Just ran into this after updating from NX 20.4.5 -> NX 20.8.2

[DrewLandgraveCbsi]

@andberg looks like they removed checkDependentProjectsHaveBeenBuilt from the buildable utils and instead have rolled the functionality into the calculateProjectDependencies If anything is missing it will instead throw an error rather than completing.

Super ugly but patching the executor for this executor

function runExecutor(options, context) {
    return tslib_1.__awaiter(this, void 0, void 0, function* () {
        const taskCommand = 'build';
        const projGraph = yield (0, project_graph_1.createProjectGraphAsync)();
        try{
          const { target, dependencies } = (0, buildable_libs_utils_1.calculateProjectDependencies)(projGraph, context.root, context.projectName, context.targetName, context.configurationName);
          const flags = createStencilCompilerOptions(taskCommand, options);
          const { strictConfig, pathCollection } = yield (0, stencil_runtime_1.initializeStencilConfig)(taskCommand, options, context, flags);
          const stencilConfig = yield (0, stencil_runtime_1.prepareConfigAndOutputargetPaths)(strictConfig, pathCollection);
          (0, buildable_libs_utils_1.updateBuildableProjectPackageJsonDependencies)(context.root, context.projectName, context.targetName, context.configurationName, target, dependencies);
          try {
              yield (0, stencil_runtime_1.createStencilProcess)(stencilConfig);
              if (stencilConfig.flags.e2e) {
                  (0, e2e_testing_1.cleanupE2eTesting)(pathCollection);
              }
              return { success: true };
          }
          catch (err) {
              devkit_1.logger.error(err.message);
              return { success: false, error: err.message };
          }
        } catch{
            return { success: false };
        }
        
    });
}

The builds work

[dgonzalezr]

I have checked our repository for any implications of removing the code related from nxext/stencil (refer to lines 22-25 in this patch)
and so far, I haven't face any problems with building or starting the stencil project in an NX monorepo. It might not be the best solution but worked in our case.
I will look for time to put together a PR considering also the suggestions from the previous comment.

[VitorTheGreat]

Hello everyone!

I still have this issue, with the latest version of nx and nxext. I have tried a few things but could not solve, do we have any news about it?

The build is working but local serve is not.

"nx": "21.1.0",
"@nxext/stencil": "^20.0.6",

My project.json

    "serve": {
      "executor": "@nxext/stencil:build",
      "outputs": ["{options.outputPath}"],
      "options": {
        "projectType": "library",
        "tsConfig": "libs/stencil/design-system/tsconfig.json",
        "configPath": "libs/stencil/design-system/stencil.config.ts",
        "outputPath": "dist/libs/stencil/design-system",
        "serve": true,
        "watch": true
      }
    }

[pawel-twardziak]

@andberg @jpthedev @MotassemJa @sonalnaik2906 @dgonzalezr @DrewLandgraveCbsi @VitorTheGreat version 20.1.0 (should have been 21.0.0 - I think @DominikPieper will release the matching version) now supports NX v21 - please, check it out and let us know if it is working now.

[andberg]

@pawel-twardziak I've actually removed the dependency to this library from our project and build our library etc only with Stencil. I couldn't wait and we're such a small team so didn't have time to fix this library.
And we are still on NX20.

[pawel-twardziak]

@pawel-twardziak I've actually removed the dependency to this library from our project and build our library etc only with Stencil. I couldn't wait and we're such a small team so didn't have time to fix this library. And we are still on NX20.

@andberg sure thing, I can understand. It's been a while without any activity on this repo.