Commit d93cce0
LF-16696 drm/imx: dpu95-h/vscaler: Initialize stream_id
The below patch kind of introduced a bug as it should have initialized
the stream_id members of struct dpu95_hscaler and struct dpu95_vscaler
to be DPU95_HSCALER_NO_STREAM_ID and DPU95_VSCALER_NO_STREAM_ID
respectively. Before that patch, the initialization is usually done
by sheer chance to the "no stream id" status by calling set_no_stream_id()
callback in dpu95_crtc_atomic_flush_scalers()/dpu95_crtc_atomic_flush()
with the first atomic commit because the scalers are usually not enabled
by that commit.
LF-16347 drm/imx: dpu95-kms: Avoid scaler engines from being
accidentally disabled
To fix the issue, explicitly initialize stream_id in dpu95_{h,v}s_init().
Without the fix, the initial value of stream_id is zero, which would be
taken as display stream 0 and hence display stream 1 would fail to use
the scalers if display stream 1 is the first one to use them.
Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
Acked-by: Jason Liu <jason.hui.liu@nxp.com>1 parent a0f9b7e commit d93cce0
2 files changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
310 | 310 | | |
311 | 311 | | |
312 | 312 | | |
| 313 | + | |
313 | 314 | | |
314 | 315 | | |
315 | 316 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
| 312 | + | |
312 | 313 | | |
313 | 314 | | |
314 | 315 | | |
0 commit comments