Avoid returning uninitialized value and reduce scope

markuspg · markuspg · commit 7699cc0d4023 · 2025-08-18T23:34:21.000+02:00
Signed-off-by: Markus Prasser &lt;markuspg@users.noreply.github.com&gt;
diff --git a/libuuu/cmd.cpp b/libuuu/cmd.cpp
@@ -253,7 +253,6 @@ int CmdBase::dump()
 int CmdList::run_all(CmdCtx *p, bool dry)
 {
 	CmdList::iterator it;
-	int ret;
 
 	uuu_notify nt;
 	nt.type = uuu_notify::NOTIFY_CMD_TOTAL;
@@ -262,6 +261,7 @@ int CmdList::run_all(CmdCtx *p, bool dry)
 
 	int i = 0;
 
+	int ret = -1;
 	for (it = begin(); it != end(); it++, i++)
 	{
 		uuu_notify nt;

Original file line number	Diff line number	Diff line change
`@@ -253,7 +253,6 @@ int CmdBase::dump()`
`253`	`253`	`int CmdList::run_all(CmdCtx *p, bool dry)`
`254`	`254`	`{`
`255`	`255`	`CmdList::iterator it;`
`256`		`- int ret;`
`257`	`256`
`258`	`257`	`uuu_notify nt;`
`259`	`258`	`nt.type = uuu_notify::NOTIFY_CMD_TOTAL;`
`@@ -262,6 +261,7 @@ int CmdList::run_all(CmdCtx *p, bool dry)`
`262`	`261`
`263`	`262`	`int i = 0;`
`264`	`263`
	`264`	`+ int ret = -1;`
`265`	`265`	`for (it = begin(); it != end(); it++, i++)`
`266`	`266`	`{`
`267`	`267`	`uuu_notify nt;`