Apply suggestions from code review

norkans7 · Copilot · web-flow · commit 03c53c46013a · 2026-02-19T12:04:56.000+02:00
Co-authored-by: Copilot &lt;175728472+Copilot@users.noreply.github.com&gt;
diff --git a/handlers/jasmin/handler.go b/handlers/jasmin/handler.go
@@ -64,7 +64,7 @@ func (h *handler) receiveStatus(ctx context.Context, c courier.Channel, w http.R
 		return nil, handlers.WriteAndLogRequestError(ctx, h, c, w, r, err)
 	}
 
-	// should have either delivered or err
+	// prefer message_status when present; otherwise require either dlvrd or err to be set
 	var reqStatus models.MsgStatus
 	msgStatus, found := statusMapping[form.MessageStatus]
 	if found {
diff --git a/handlers/jasmin/handler_test.go b/handlers/jasmin/handler_test.go
@@ -56,7 +56,7 @@ var handleTestCases = []IncomingTestCase{
 		ExpectedStatuses:     []ExpectedStatus{{ExternalID: "external1", Status: models.MsgStatusDelivered}},
 	},
 	{
-		Label:                "Status Delivered",
+		Label:                "Status Delivered via message_status",
 		URL:                  statusURL,
 		Data:                 "id=external1&dlvrd=001&message_status=DELIVRD",
 		ExpectedRespStatus:   200,

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ func (h *handler) receiveStatus(ctx context.Context, c courier.Channel, w http.R`
`64`	`64`	`return nil, handlers.WriteAndLogRequestError(ctx, h, c, w, r, err)`
`65`	`65`	`}`
`66`	`66`
`67`		`- // should have either delivered or err`
	`67`	`+ // prefer message_status when present; otherwise require either dlvrd or err to be set`
`68`	`68`	`var reqStatus models.MsgStatus`
`69`	`69`	`msgStatus, found := statusMapping[form.MessageStatus]`
`70`	`70`	`if found {`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ var handleTestCases = []IncomingTestCase{`
`56`	`56`	`ExpectedStatuses: []ExpectedStatus{{ExternalID: "external1", Status: models.MsgStatusDelivered}},`
`57`	`57`	`},`
`58`	`58`	`{`
`59`		`- Label: "Status Delivered",`
	`59`	`+ Label: "Status Delivered via message_status",`
`60`	`60`	`URL: statusURL,`
`61`	`61`	`Data: "id=external1&dlvrd=001&message_status=DELIVRD",`
`62`	`62`	`ExpectedRespStatus: 200,`