Skip to content

Commit 3bfd3be

Browse files
committed
Make sure sent_on is properly set for read status
1 parent 6137e85 commit 3bfd3be

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

Diff for: backends/rapidpro/backend_test.go

+9
Original file line numberDiff line numberDiff line change
@@ -518,6 +518,15 @@ func (ts *BackendTestSuite) TestMsgStatus() {
518518
ts.True(m.SentOn_.Equal(sentOn)) // no change
519519
ts.Equal(pq.StringArray([]string{string(clog1.UUID()), string(clog2.UUID()), string(clog3.UUID())}), m.LogUUIDs)
520520

521+
// update to READ using id
522+
clog4 := updateStatusByID(10001, courier.MsgStatusRead, "")
523+
524+
m = readMsgFromDB(ts.b, 10001)
525+
ts.Equal(m.Status_, courier.MsgStatusRead)
526+
ts.True(m.ModifiedOn_.After(now))
527+
ts.True(m.SentOn_.Equal(sentOn)) // no change
528+
ts.Equal(pq.StringArray([]string{string(clog1.UUID()), string(clog2.UUID()), string(clog3.UUID()), string(clog4.UUID())}), m.LogUUIDs)
529+
521530
// no change for incoming messages
522531
updateStatusByID(10002, courier.MsgStatusSent, "")
523532

Diff for: backends/rapidpro/status.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ UPDATE msgs_msg SET
9090
END,
9191
sent_on = CASE
9292
WHEN
93-
s.status IN ('W', 'S', 'D')
93+
s.status IN ('W', 'S', 'D', 'R')
9494
THEN
9595
COALESCE(sent_on, NOW())
9696
ELSE

0 commit comments

Comments
 (0)