Merge pull request #826 from nyaruka/EX-response-check

Do not log EX MT response check error

Author: rowanseymour

Diff for: handlers/external/handler.go

@@ -366,7 +366,7 @@ func (h *handler) Send(ctx context.Context, msg courier.MsgOut, res *courier.Sen
 		}
 
 		if responseCheck != "" && !strings.Contains(string(respBody), responseCheck) {
-			return courier.ErrResponseUnexpected
+			return courier.ErrResponseUnexpectedUnlogged
 		}
 	}
 

Diff for: handlers/external/handler_test.go

@@ -834,7 +834,7 @@ var xmlSendWithResponseContentTestCases = []OutgoingTestCase{
 			Headers: map[string]string{"Content-Type": "text/xml; charset=utf-8"},
 			Body:    `<msg><to>+250788383383</to><text>Error Message</text><from>2020</from><quick_replies></quick_replies></msg>`,
 		}},
-		ExpectedError: courier.ErrResponseUnexpected,
+		ExpectedError: courier.ErrResponseUnexpectedUnlogged,
 	},
 	{
 		Label:          "Send Attachment",

Diff for: sender.go

@@ -110,6 +110,15 @@ var ErrResponseUnexpected error = &SendError{
 	clogMsg:   "Response doesn't match expected values.",
 }
 
+// ErrResponseUnexpectedUnlogged is same as ErrResponseUnexpected without logging so better for channels where response check is user configured.
+var ErrResponseUnexpectedUnlogged error = &SendError{
+	msg:       "response not expected values",
+	retryable: false,
+	loggable:  false,
+	clogCode:  "response_unexpected",
+	clogMsg:   "Response doesn't match expected values.",
+}
+
 // ErrContactStopped should be returned when channel tells us explicitly that the contact has opted-out
 var ErrContactStopped error = &SendError{
 	msg:       "contact opted out",