Rename to use delete_contact

Author: norkans7

Diff for: channel_event.go

@@ -21,7 +21,7 @@ const (
 	EventTypeWelcomeMessage  ChannelEventType = "welcome_message"
 	EventTypeOptIn           ChannelEventType = "optin"
 	EventTypeOptOut          ChannelEventType = "optout"
-	EventDeletionRequest     ChannelEventType = "delete_request"
+	EventDeleteContact       ChannelEventType = "delete_contact"
 )
 
 //-----------------------------------------------------------------------------

Diff for: handlers/meta/facebook_test.go

@@ -336,7 +336,7 @@ func TestDeleteRequest(t *testing.T) {
 			NoInvalidChannelCheck: true,
 			NoLogsExpected:        true,
 			ExpectedEvents: []ExpectedEvent{
-				{Type: courier.EventDeletionRequest, URN: "facebook:218471", Extra: map[string]string{"userID": "218471"}},
+				{Type: courier.EventDeleteContact, URN: "facebook:218471", Extra: map[string]string{"userID": "218471"}},
 			},
 		},
 		{

Diff for: handlers/meta/handlers.go

@@ -87,7 +87,7 @@ func (h *handler) Initialize(s courier.Server) error {
 	h.SetServer(s)
 	s.AddHandlerRoute(h, http.MethodGet, "receive", courier.ChannelLogTypeWebhookVerify, h.receiveVerify)
 	s.AddHandlerRoute(h, http.MethodPost, "receive", courier.ChannelLogTypeMultiReceive, handlers.JSONPayload(h, h.receiveEvents))
-	s.AddHandlerRoute(h, http.MethodPost, "delete", courier.ChannelLogTypeEventReceive, handlers.JSONPayload(h, h.deleteEvents))
+	s.AddHandlerRoute(h, http.MethodPost, "delete", courier.ChannelLogTypeEventReceive, handlers.JSONPayload(h, h.deleteContactEvents))
 	return nil
 }
 
@@ -229,8 +229,8 @@ type DeleteConfirmationData struct {
 	ConfirmationCode string `json:"confirmation_code"`
 }
 
-// deleteEvents is our HTTP handler function for deleting data requests
-func (h *handler) deleteEvents(ctx context.Context, channel courier.Channel, w http.ResponseWriter, r *http.Request, payload *DeletionRequestData, clog *courier.ChannelLog) ([]courier.Event, error) {
+// deleteContactEvents is our HTTP handler function for deleting data requests
+func (h *handler) deleteContactEvents(ctx context.Context, channel courier.Channel, w http.ResponseWriter, r *http.Request, payload *DeletionRequestData, clog *courier.ChannelLog) ([]courier.Event, error) {
 	err := h.validateSignature(r)
 	if err != nil {
 		return nil, handlers.WriteAndLogRequestError(ctx, h, channel, w, r, err)
@@ -248,7 +248,7 @@ func (h *handler) deleteEvents(ctx context.Context, channel courier.Channel, w h
 	payloadJson, _ := json.Marshal(payload)
 	sentry.CaptureMessage(fmt.Sprintf("Data Deletion Request: %s", payloadJson))
 
-	event := h.Backend().NewChannelEvent(channel, courier.EventDeletionRequest, urn, clog).WithOccurredOn(date).WithExtra(map[string]string{"userID": payload.UserID})
+	event := h.Backend().NewChannelEvent(channel, courier.EventDeleteContact, urn, clog).WithOccurredOn(date).WithExtra(map[string]string{"userID": payload.UserID})
 
 	err = h.Backend().WriteChannelEvent(ctx, event, clog)
 	if err != nil {