Add channel log for error with line attachments #711
Conversation
handlers/line/handler.go
Outdated
| @@ -317,6 +317,8 @@ func (h *handler) Send(ctx context.Context, msg courier.MsgOut, res *courier.Sen | |||
|
|
|||
| if err == nil { | |||
| jsonMsgs = append(jsonMsgs, string(jsonMsg)) | |||
| } else { | |||
| clog.Error(courier.NewChannelError("", "", err.Error())) | |||
There was a problem hiding this comment.
This line will help see why the attachments was not send
There was a problem hiding this comment.
if marshaling those things is creating an error.. .then just return that err (return err) and we'll fix it... but I'm not convinced this is where the problem is
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
- Coverage 74.24% 74.22% -0.02%
==========================================
Files 110 110
Lines 13325 13327 +2
==========================================
- Hits 9893 9892 -1
- Misses 2718 2720 +2
- Partials 714 715 +1 ☔ View full report in Codecov by Sentry. |
handlers/line/handler.go
Outdated
| @@ -317,6 +317,8 @@ func (h *handler) Send(ctx context.Context, msg courier.MsgOut, res *courier.Sen | |||
|
|
|||
| if err == nil { | |||
| jsonMsgs = append(jsonMsgs, string(jsonMsg)) | |||
| } else { | |||
| clog.Error(courier.NewChannelError("", "", err.Error())) | |||
There was a problem hiding this comment.
if marshaling those things is creating an error.. .then just return that err (return err) and we'll fix it... but I'm not convinced this is where the problem is
norkans7
force-pushed
the
line-attachnment-err-log
branch
from
51f9ea3 to
59765cb
Compare
No description provided.