Unresolveable media should create channel log error #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Mar 12, 2024
| @@ -56,18 +55,15 @@ func ErrorResponseValueMissing(key string) *ChannelError { | |||
| return NewChannelError("response_value_missing", "", "Unable to find '%s' response.", key) | |||
| } | |||
|
|
|||
| func ErrorResponseValueUnexpected(key string, expected ...string) *ChannelError { | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
==========================================
- Coverage 74.22% 74.19% -0.03%
==========================================
Files 110 110
Lines 13327 13325 -2
==========================================
- Hits 9892 9887 -5
- Misses 2720 2722 +2
- Partials 715 716 +1 ☔ View full report in Codecov by Sentry. |
norkans7
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.