Skip to content

Remove S3 region is media hostname before matching the media domain #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

norkans7
Copy link
Contributor

No description provided.

@norkans7 norkans7 requested a review from rowanseymour March 12, 2024 16:01
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (6019d3d) to head (993344a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   74.22%   74.29%   +0.07%     
==========================================
  Files         110      110              
  Lines       13327    13379      +52     
==========================================
+ Hits         9892     9940      +48     
- Misses       2720     2723       +3     
- Partials      715      716       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkans7 norkans7 force-pushed the fix-media-resolve branch from 6d779da to 993344a Compare March 12, 2024 16:18
@rowanseymour rowanseymour merged commit ebd5ad8 into main Mar 12, 2024
7 checks passed
@rowanseymour rowanseymour deleted the fix-media-resolve branch March 12, 2024 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants