Messagebird Handler Updates

[tybritten]

Updated to support Messagebird's default webhook receiving handlers, with both shortcodes and regular numbers.

[codecov]

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.66%. Comparing base (652f428) to head (b034530).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
handlers/messagebird/handler.go	81.81%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #841      +/-   ##
==========================================
+ Coverage   74.65%   74.66%   +0.01%     
==========================================
  Files         113      113              
  Lines       13308    13326      +18     
==========================================
+ Hits         9935     9950      +15     
- Misses       2658     2660       +2     
- Partials      715      716       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[norkans7]

Why not keep expecting the JSON format for this handler?

[tybritten]

the default webhook on MB is urlencoded, we were using a internal flow with them that turned it to json (among other things) before we found out they charge extra for these.

[norkans7]

Changing that will require you update each existing callback to use the default urlencoded again, I imagine those are now set to use JSON when submitting

[tybritten]

surprisingly sending with MB is either json or urlencoded, so that doesn't need to change. Since we only use them for shortcodes, we have a patch of our current courier with some of these changes just so we could move back to their default webhook to cut our SMS costs

[norkans7]

I think we can keep expecting JSON, and make that clear on the config page https://github.com/nyaruka/rapidpro/blob/main/temba/channels/types/messagebird/type.py#L35 that the callback should be configured with JSON

[rowanseymour]

Let's take a look and see if we have customers using messagebird that way... it would be nice to support whatever the default setup is for this channel.

[tybritten]

its basically like the difference between using the twilio webhook, or using a twilio function to convert the message to json. there's a cost associated that they don't make clear. the actual webhook from the number is always form encoded, you have to manually set up a flow (function) to convert. We did that before we knew there was a cost per run of that flow.

[rowanseymour]

Ok we have no channels of this type in prod probably because the type has always been beta gated. Since the default way to connect this channel sends urlencoded params, that's what we should support. And when we've merged this and tested it.. let's un- beta gate it.