Merge pull request #1338 from nyaruka/fix_empty_cate_names

Amend 14.0 migration to also fix empty category names

Author: rowanseymour

flows/definition/migrations/13_x.go

@@ -24,8 +24,8 @@ func init() {
 	registerMigration(semver.MustParse("13.1.0"), Migrate13_1)
 }
 
-// Migrate14.0 fixes invalid expires values. Note that this is a major version change because of other additions to the
-// flow spec that don't require migration.
+// Migrate14.0 fixes invalid expires values and categories with missing names.
+// Note that this is a major version change because of other additions to the flow spec that don't require migration.
 //
 // @version 14_0 "14.0"
 func Migrate14_0(f Flow, cfg *Config) (Flow, error) {
@@ -45,6 +45,22 @@ func Migrate14_0(f Flow, cfg *Config) (Flow, error) {
 		}
 	}
 
+	for _, node := range f.Nodes() {
+		router := node.Router()
+		if router != nil {
+			categories, _ := router["categories"].([]any)
+			for _, cat := range categories {
+				category, _ := cat.(map[string]any)
+				if category != nil {
+					name, _ := category["name"].(string)
+					if name == "" {
+						category["name"] = "Match"
+					}
+				}
+			}
+		}
+	}
+
 	return f, nil
 }
 

flows/definition/migrations/testdata/migrations/14.0.0.json

@@ -88,5 +88,86 @@
             "localization": {},
             "nodes": []
         }
+    },
+    {
+        "description": "flow with empty category name",
+        "original": {
+            "uuid": "25a2d8b2-ae7c-4fed-964a-506fb8c3f0c0",
+            "name": "Test Flow",
+            "spec_version": "13.6.1",
+            "language": "eng",
+            "type": "messaging",
+            "localization": {},
+            "nodes": [
+                {
+                    "uuid": "4c83851e-f0bf-4c59-ba11-220ecccfcebb",
+                    "router": {
+                        "type": "switch",
+                        "categories": [
+                            {
+                                "uuid": "3c9edf35-7386-4d1c-9d37-fd1b4fa68792",
+                                "name": "",
+                                "exit_uuid": "fc2fcd23-7c4a-44bd-a8c6-6c88e6ed09f8"
+                            },
+                            {
+                                "uuid": "37d8813f-1402-4ad2-9cc2-e9054a96525b",
+                                "name": "Other",
+                                "exit_uuid": "d3356ec1-1686-4c64-8a51-ee36129e48ae"
+                            }
+                        ],
+                        "default_category_uuid": "37d8813f-1402-4ad2-9cc2-e9054a96525b",
+                        "operand": "@input.text",
+                        "cases": []
+                    },
+                    "exits": [
+                        {
+                            "uuid": "fc2fcd23-7c4a-44bd-a8c6-6c88e6ed09f8"
+                        },
+                        {
+                            "uuid": "d3356ec1-1686-4c64-8a51-ee36129e48ae"
+                        }
+                    ]
+                }
+            ]
+        },
+        "migrated": {
+            "uuid": "25a2d8b2-ae7c-4fed-964a-506fb8c3f0c0",
+            "name": "Test Flow",
+            "spec_version": "14.0.0",
+            "language": "eng",
+            "type": "messaging",
+            "localization": {},
+            "nodes": [
+                {
+                    "uuid": "4c83851e-f0bf-4c59-ba11-220ecccfcebb",
+                    "router": {
+                        "type": "switch",
+                        "categories": [
+                            {
+                                "uuid": "3c9edf35-7386-4d1c-9d37-fd1b4fa68792",
+                                "name": "Match",
+                                "exit_uuid": "fc2fcd23-7c4a-44bd-a8c6-6c88e6ed09f8"
+                            },
+                            {
+                                "uuid": "37d8813f-1402-4ad2-9cc2-e9054a96525b",
+                                "name": "Other",
+                                "exit_uuid": "d3356ec1-1686-4c64-8a51-ee36129e48ae"
+                            }
+                        ],
+                        "default_category_uuid": "37d8813f-1402-4ad2-9cc2-e9054a96525b",
+                        "operand": "@input.text",
+                        "cases": []
+                    },
+                    "exits": [
+                        {
+                            "uuid": "fc2fcd23-7c4a-44bd-a8c6-6c88e6ed09f8"
+                        },
+                        {
+                            "uuid": "d3356ec1-1686-4c64-8a51-ee36129e48ae"
+                        }
+                    ]
+                }
+            ]
+        }
     }
 ]