Limit groups and label actions to 100 items

Author: rowanseymour

flows/actions/add_contact_groups.go

@@ -32,7 +32,7 @@ type AddContactGroupsAction struct {
 	baseAction
 	universalAction
 
-	Groups []*assets.GroupReference `json:"groups" validate:"required,dive"`
+	Groups []*assets.GroupReference `json:"groups" validate:"required,max=100,dive"`
 }
 
 // NewAddContactGroups creates a new add to groups action

flows/actions/add_input_labels.go

@@ -33,7 +33,7 @@ type AddInputLabelsAction struct {
 	baseAction
 	interactiveAction
 
-	Labels []*assets.LabelReference `json:"labels" validate:"required,dive"`
+	Labels []*assets.LabelReference `json:"labels" validate:"required,max=100,dive"`
 }
 
 // NewAddInputLabels creates a new add labels action

flows/actions/base.go

@@ -258,9 +258,9 @@ func (a *otherContactsAction) resolveRecipients(run flows.Run, logEvent flows.Ev
 
 // utility struct for actions which create a message
 type createMsgAction struct {
-	Text         string   `json:"text"                    validate:"required"        engine:"localized,evaluated"`
-	Attachments  []string `json:"attachments,omitempty"   validate:"dive,attachment" engine:"localized,evaluated"`
-	QuickReplies []string `json:"quick_replies,omitempty"                            engine:"localized,evaluated"`
+	Text         string   `json:"text"                    validate:"required"               engine:"localized,evaluated"`
+	Attachments  []string `json:"attachments,omitempty"   validate:"max=10,dive,attachment" engine:"localized,evaluated"`
+	QuickReplies []string `json:"quick_replies,omitempty" validate:"max=10,dive,max=64"     engine:"localized,evaluated"`
 }
 
 // helper function for actions that have a set of group references that must be resolved to actual groups

flows/actions/set_run_local.go

@@ -40,7 +40,7 @@ type SetRunLocalAction struct {
 	baseAction
 	universalAction
 
-	Local     string         `json:"local"                               validate:"required,local_ref"`
+	Local     string         `json:"local"                              validate:"required,local_ref"`
 	Value     string         `json:"value,omitempty" engine:"evaluated" validate:"max=1000"`
 	Operation LocalOperation `json:"operation"                          validate:"required,eq=set|eq=increment|eq=clear"`
 }

flows/actions/testdata/add_contact_groups.json

@@ -1,4 +1,18 @@
 [
+    {
+        "description": "Read fails when invalid group reference",
+        "action": {
+            "type": "add_contact_groups",
+            "uuid": "ad154980-7bf7-4ab8-8728-545fd6378912",
+            "groups": [
+                {
+                    "uuid": "x",
+                    "name": "1"
+                }
+            ]
+        },
+        "read_error": "field 'groups[0].uuid' must be a valid UUID4"
+    },
     {
         "description": "Error event and NOOP for missing group",
         "action": {

flows/actions/testdata/send_msg.json

@@ -1,25 +1,51 @@
 [
     {
-        "description": "Read fails when text is empty",
+        "description": "Read fails when text is empty or too many attachments",
         "action": {
             "type": "send_msg",
             "uuid": "ad154980-7bf7-4ab8-8728-545fd6378912",
             "text": "",
             "attachments": [
-                "image:http://example.com/red.jpg"
+                "image:http://example.com/1.jpg",
+                "image:http://example.com/2.jpg",
+                "image:http://example.com/3.jpg",
+                "image:http://example.com/4.jpg",
+                "image:http://example.com/5.jpg",
+                "image:http://example.com/6.jpg",
+                "image:http://example.com/7.jpg",
+                "image:http://example.com/8.jpg",
+                "image:http://example.com/9.jpg",
+                "image:http://example.com/10.jpg",
+                "image:http://example.com/11.jpg"
+            ],
+            "quick_replies": [
+                "1",
+                "2",
+                "3",
+                "4",
+                "5",
+                "6",
+                "7",
+                "8",
+                "9",
+                "10",
+                "11"
             ]
         },
-        "read_error": "field 'text' is required"
+        "read_error": "field 'text' is required, field 'attachments' must have a maximum of 10 items, field 'quick_replies' must have a maximum of 10 items"
     },
     {
-        "description": "Read fails when topic is invalid",
+        "description": "Read fails when topic is invalid or a quick reply is too long",
         "action": {
             "type": "send_msg",
             "uuid": "ad154980-7bf7-4ab8-8728-545fd6378912",
             "text": "hi there",
-            "topic": "spam"
+            "topic": "spam",
+            "quick_replies": [
+                "1234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890"
+            ]
         },
-        "read_error": "field 'topic' is not a valid message topic"
+        "read_error": "field 'quick_replies[0]' must be less than or equal to 64, field 'topic' is not a valid message topic"
     },
     {
         "description": "Error events if msg text, attachments and quick replies have expression errors",
@@ -197,7 +223,7 @@
             "text": "Hi there",
             "quick_replies": [
                 "yes",
-                "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua."
+                "@(repeat(\"1234567890\", 10))"
             ]
         },
         "events": [
@@ -218,7 +244,7 @@
                             "text": "yes"
                         },
                         {
-                            "text": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed ..."
+                            "text": "1234567890123456789012345678901234567890123456789012345678901..."
                         }
                     ],
                     "locale": "eng-US"