Merge pull request #198 from nyaruka/fix_lock_copy

Fix copying mutex in number desc

Author: rowanseymour

matcher.go

@@ -212,7 +212,7 @@ func AllNumberGroupsAreExactlyPresent(
 
 // Returns whether the given national number (a string containing only decimal digits) matches
 // the national number pattern defined in the given PhoneNumberDesc message.
-func MatchNationalNumber(number string, numberDesc PhoneNumberDesc, allowPrefixMatch bool) bool {
+func MatchNationalNumber(number string, numberDesc *PhoneNumberDesc, allowPrefixMatch bool) bool {
 	nationalNumberPattern := numberDesc.GetNationalNumberPattern()
 	// We don't want to consider it a prefix match when matching non-empty input against an empty pattern.
 	if len(nationalNumberPattern) == 0 {

shortnumber_info.go

@@ -182,7 +182,7 @@ func matchesPossibleNumberAndNationalNumber(number string, numberDesc *PhoneNumb
 	if len(numberDesc.PossibleLength) > 0 && !numberDesc.hasPossibleLength(int32(len(number))) {
 		return false
 	}
-	return MatchNationalNumber(number, *numberDesc, false)
+	return MatchNationalNumber(number, numberDesc, false)
 }
 
 // In these countries, if extra digits are added to an emergency number, it no longer connects
@@ -206,7 +206,7 @@ func matchesEmergencyNumber(number string, regionCode string, allowPrefixMatch b
 	normalizedNumber := NormalizeDigitsOnly(possibleNumber)
 
 	allowPrefixMatchForRegion := allowPrefixMatch && !slices.Contains(REGIONS_WHERE_EMERGENCY_NUMBERS_MUST_BE_EXACT, regionCode)
-	return MatchNationalNumber(normalizedNumber, *phoneMetadata.GetEmergency(), allowPrefixMatchForRegion)
+	return MatchNationalNumber(normalizedNumber, phoneMetadata.GetEmergency(), allowPrefixMatchForRegion)
 }
 
 // Returns true if the given number exactly matches an emergency service number in the given