Coverage updates

Author: ericnewcomer

temba/users/adapter.py

@@ -21,7 +21,8 @@ def post_login(self, request, user, *, email_verification, signal_kwargs, email,
         if secret:
             invite = Invitation.objects.filter(secret=secret, is_active=True).first()
             if invite:
-                if user.email != invite.email:
+                # this can happen if a SSO with a different email address is used
+                if user.email != invite.email:  # pragma: no cover
                     messages.add_message(
                         self.request,
                         messages.WARNING,
@@ -57,14 +58,14 @@ def is_open_for_signup(self, request):
 
 
 class TembaSocialAccountAdapter(InviteAdapterMixin, DefaultSocialAccountAdapter):
-    def save_user(self, request, sociallogin, form=None):
+    def save_user(self, request, sociallogin, form=None):  # pragma: no cover
         user = super().save_user(request, sociallogin, form)
         user.fetch_avatar(sociallogin.account.get_avatar_url())
         return user
 
 
 @receiver(social_account_added)
-def update_user_profile_picture(request, sociallogin, **kwargs):
+def update_user_profile_picture(request, sociallogin, **kwargs):  # pragma: no cover
     user = sociallogin.user
     user.fetch_avatar(sociallogin.account.get_avatar_url())
 

temba/users/forms.py

@@ -93,7 +93,9 @@ def __init__(self, secret, *args, **kwargs):
     def clean_login(self):
         if self.invite:
             return self.invite.email
-        return super().clean_login()
+
+        # this is tested by allauth
+        return super().clean_login()  # pragma: no cover
 
 
 class TembaChangePasswordForm(ChangePasswordForm):

temba/users/models.py

@@ -269,7 +269,7 @@ def get_api_tokens(self, org):
     def as_engine_ref(self) -> dict:
         return {"email": self.email, "name": self.name}
 
-    def fetch_avatar(self, url: str):
+    def fetch_avatar(self, url: str):  # pragma: no cover
         # fetch the avatar from the url and store it locally
         self.avatar.save(f"{self.pk}_profile.jpg", ContentFile(requests.get(url).content), save=True)
 

temba/users/views.py

@@ -24,19 +24,12 @@ def invite(self):
 
     def get_initial(self):
         initial = super().get_initial()
-
-        if self.request.method == "GET":
-            secret = self.request.GET.get("invite")
-
-        secret = self.request.session.get("invite_secret", None)
-        if secret:
-            self.invite = Invitation.objects.filter(secret=secret, is_active=True).first()
-            if not self.invite:
-                messages.add_message(
-                    self.request,
-                    messages.WARNING,
-                    _("Sorry, your invitation is no longer valid. Please request a new invite."),
-                )
+        if not self.invite:
+            messages.add_message(
+                self.request,
+                messages.WARNING,
+                _("Sorry, your invitation is no longer valid. Please request a new invite."),
+            )
 
         return initial