Skip to content

Commit 4491aeb

Browse files
author
Andrew Welch
committed
Merge branch 'release/2.6.5' into devmode-vite
2 parents 1137dc7 + e9c0a96 commit 4491aeb

File tree

5 files changed

+418
-404
lines changed

5 files changed

+418
-404
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# nystudio107/devmode Change Log
22

3+
## 2.6.5 - 2022.05.04
4+
### Added
5+
* Determine the container name separator character by checking the Docker Compose API version at runtime
6+
*
7+
### Changed
8+
* Updated to release version of Craft CMS 4
9+
310
## 2.6.4 - 2022.05.02
411
### Fixed
512
* Clean up initial check for `composer.lock` or `vendor/autoload.php` to ensure the first-time install is done

Makefile

+15-8
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,31 @@
1-
CONTAINER?=$(shell basename $(CURDIR))-php-1
2-
BUILDCHAIN?=$(shell basename $(CURDIR))-vite-1
1+
# Determine the docker compose API version to get the separator character
2+
VERSION?=$(shell docker-compose -v)
3+
ifneq (,$(findstring v2.,$(VERSION)))
4+
SEPARATOR:=-
5+
else
6+
SEPARATOR:=_
7+
endif
8+
CONTAINER?=$(shell basename $(CURDIR))$(SEPARATOR)php$(SEPARATOR)1
9+
BUILDCHAIN?=$(shell basename $(CURDIR))$(SEPARATOR)vite$(SEPARATOR)1
310

411
.PHONY: build clean composer craft dev npm pulldb restoredb nuke ssh up
512

613
build: up
7-
docker exec -it ${BUILDCHAIN} npm run build
14+
docker exec -it $(BUILDCHAIN) npm run build
815
clean:
916
rm -f cms/composer.lock
1017
rm -rf cms/vendor/
1118
rm -f buildchain/package-lock.json
1219
rm -rf buildchain/node_modules/
1320
composer: up
14-
docker exec -it ${CONTAINER} su-exec www-data composer \
21+
docker exec -it $(CONTAINER) su-exec www-data composer \
1522
$(filter-out $@,$(MAKECMDGOALS))
1623
craft: up
17-
docker exec -it ${CONTAINER} su-exec www-data php craft \
24+
docker exec -it $(CONTAINER) su-exec www-data php craft \
1825
$(filter-out $@,$(MAKECMDGOALS))
1926
dev: up
2027
npm: up
21-
docker exec -it ${BUILDCHAIN} npm \
28+
docker exec -it $(BUILDCHAIN) npm \
2229
$(filter-out $@,$(MAKECMDGOALS))
2330
pulldb: up
2431
cd scripts/ && ./docker_pull_db.sh
@@ -29,9 +36,9 @@ nuke: clean
2936
docker-compose down -v
3037
docker-compose up --build --force-recreate
3138
ssh:
32-
docker exec -it ${CONTAINER} su-exec www-data /bin/sh
39+
docker exec -it $(CONTAINER) su-exec www-data /bin/sh
3340
up:
34-
if [ ! "$$(docker ps -q -f name=${CONTAINER})" ]; then \
41+
if [ ! "$$(docker ps -q -f name=$(CONTAINER))" ]; then \
3542
cp -n cms/example.env cms/.env; \
3643
docker-compose up; \
3744
fi

0 commit comments

Comments
 (0)