Skip to content

Commit 708d13f

Browse files
author
adam tecle
authored
Merge pull request #287 from nytimes/develop
Merge develop into master
2 parents d9cf272 + 0d98e88 commit 708d13f

File tree

3 files changed

+23
-7
lines changed

3 files changed

+23
-7
lines changed

CHANGELOG.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,19 @@
22

33
Changes for users of the library currently on `develop`:
44

5-
- Fixed some tests, added tests for NYTPhotoViewerSinglePhotoDataSource
6-
- Fixed a strict warning and a subscripting bug in NYTPhotoViewerArrayDataSource.m
7-
- Added support for interstitial views
5+
## [3.0.1](https://github.com/nytimes/NYTPhotoViewer/releases/tag/3.0.1)
6+
7+
Changes for users of the library in 3.0.1:
8+
9+
- Fixed issue with beginAppearanceTransition being called on VCs with no parent VC
10+
11+
## [3.0.0](https://github.com/nytimes/NYTPhotoViewer/releases/tag/3.0.0)
12+
13+
Changes for users of the library in 3.0.0:
14+
15+
- Unit test improvements
16+
- Interstitial view support + Swift sample
17+
- NSObject conformance for example app
818

919
## [2.0.0](https://github.com/NYTimes/NYTPhotoViewer/releases/tag/2.0.0)
1020

NYTPhotoViewer.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "NYTPhotoViewer"
3-
s.version = "3.0.0"
3+
s.version = "3.0.1"
44

55
s.description = <<-DESC
66
NYTPhotoViewer is a slideshow and image viewer that includes double tap to zoom, captions, support for multiple images, interactive flick to dismiss, animated zooming presentation, and more.

NYTPhotoViewer/NYTPhotoTransitionAnimator.m

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,15 @@ - (void)setupTransitionContainerHierarchyWithTransitionContext:(id <UIViewContro
5252
self.fromViewController = [transitionContext viewControllerForKey:UITransitionContextFromViewControllerKey];
5353

5454
toView.frame = [transitionContext finalFrameForViewController:self.toViewController];
55-
[self.toViewController beginAppearanceTransition:YES animated:YES];
56-
[self.fromViewController beginAppearanceTransition:NO animated:YES];
57-
55+
56+
if (self.toViewController.parentViewController) {
57+
[self.toViewController beginAppearanceTransition:YES animated:YES];
58+
}
59+
60+
if (self.fromViewController.parentViewController) {
61+
[self.fromViewController beginAppearanceTransition:NO animated:YES];
62+
}
63+
5864
if (![toView isDescendantOfView:transitionContext.containerView]) {
5965
[transitionContext.containerView addSubview:toView];
6066
}

0 commit comments

Comments
 (0)