Improve pooping command

Author: l7ssha

lib/src/commands/admin.dart

@@ -8,25 +8,6 @@ import 'package:running_on_dart/src/modules/poop_name.dart';
 import 'package:running_on_dart/src/init.dart';
 import 'package:running_on_dart/src/util/util.dart';
 
-Future<MessageBuilder> createMessageBuilder(List<String> nicknames, String messageHeader) async {
-  if (nicknames.isEmpty) {
-    return MessageBuilder(content: "-/-");
-  }
-
-  return pagination.split(
-    nicknames.join(','),
-    buildChunk: (String chunk) => MessageBuilder(
-      content:
-          """
-$messageHeader:
-```
-$chunk
-```
-""",
-    ),
-  );
-}
-
 Stream<Member> searchMembers(String disallowedChar, int batchSize, Guild guild) {
   return (guild.manager.client as NyxxGateway).gateway.listGuildMembers(
     guild.id,
@@ -71,11 +52,11 @@ final admin = ChatGroup(
     ChatCommand(
       "perform-nickname-pooping",
       "Perform pooping of usernames in current guild",
-      id('perform-nickname-pooping', (ChatContext context, [int batchSize = 100]) async {
+      id('perform-nickname-pooping', (ChatContext context, [int batchSize = 10]) async {
         final poopModule = Injector.appInstance.get<PoopNameModule>();
 
         final membersToPoop = <Member>[];
-        for (final disallowedChar in poopCharacters) {
+        for (final disallowedChar in minimalPoopCharacters) {
           await for (final member in searchMembers(disallowedChar, batchSize, context.guild!)) {
             final shouldBePooped = await poopModule.poopMember(member, dryRun: true);
             if (shouldBePooped) {
@@ -84,6 +65,10 @@ final admin = ChatGroup(
           }
         }
 
+        if (membersToPoop.isEmpty) {
+          return context.respond(MessageBuilder(content: 'No members to poop...'));
+        }
+
         final multiSelectResult = await context.getMultiSelection(
           membersToPoop,
           MessageBuilder(content: 'Performing members pooping...'),
@@ -97,7 +82,8 @@ final admin = ChatGroup(
 
         await context.respond(
           MessageBuilder(
-            content: 'Pooped members: `${multiSelectResult.map((value) => poopModule.getMemberNameForPooping(value))}`',
+            content:
+                'Pooped members: ${multiSelectResult.map((value) => poopModule.getMemberNameForPooping(value)).map((v) => '`$v`').join(', ')}',
           ),
         );
       }),

lib/src/modules/poop_name.dart

@@ -35,6 +35,8 @@ const poopCharacters = [
   '*',
 ];
 
+const minimalPoopCharacters = ['.', "'", '<', '[', '!', '@', r'$', '^', '*'];
+
 final poopRegexp = RegExp("[${poopCharacters.map((c) => RegExp.escape(c)).join()}]");
 final weirdCharsRegexp = RegExp(
   r'[\u200B\u200C\u200D\u2060\uFEFF\u180E\u202A-\u202E\u2066-\u2069\u00AD\u061C\uFFF9-\uFFFB\uFFFD]|[\x00-\x1F\x7F-\x9F]',