Chore: cleanup devcontainer

Author: johanmartindev

.github/.devcontainer/devcontainer.json

@@ -87,6 +87,7 @@
       "upgradePackages": "true"
     },
     "ghcr.io/devcontainers/features/git:1": {},
+    "ghcr.io/devcontainers/features/node:1": {},
     "ghcr.io/devcontainers/features/github-cli:1": {
       "installDirectlyFromGitHubRelease": true,
       "version": "latest"

devcontainer.json

@@ -4,7 +4,7 @@
   "service": "app",
   "workspaceFolder": "/workspace",
   "postCreateCommand": "bash .devcontainer/scripts/post-create.sh",
-  "onCreateCommand": "bash .devcontainer/scripts/setup-dotnet-dev-cert.sh",
+  // "onCreateCommand": "bash .devcontainer/scripts/setup-dotnet-dev-cert.sh",
   "postAttachCommand": "bash -i .devcontainer/scripts/post-attach.sh",
   "customizations": {
     "vscode": {
@@ -38,7 +38,6 @@
     // },
     // "ghcr.io/devcontainers/features/aws-cli:1": {},
     // "ghcr.io/devcontainers/features/azure-cli:1": {},
-    "ghcr.io/devcontainers/features/node:1": {}
     // "ghcr.io/devcontainers/features/python:1": {
     //   "version": "3.12"
     // }

scripts/post-create.sh

@@ -1,4 +1,5 @@
 #!/usr/bin/env zsh
 set -xe
-. ${NVM_DIR}/nvm.sh && nvm install --lts --latest-npm --default --save
+. ${NVM_DIR}/nvm.sh
+nvm install --lts --latest-npm --default --save
 npm install -g typescript prettier prettier aws-cdk