SERVER: Introduce FTE reimplementation of Vril achievement builtin; early-out achievements

Author: MotoLegacy

progs/ssqc.src

@@ -20,6 +20,7 @@ defs/standard.qc
 #endif
 shared_defs.qc
 defs/custom.qc
+fte_builtins.qc
 map_rotation.qc
 utilities/sound_helper.qc
 weapon_stats.qc

source/server/clientfuncs.qc

@@ -484,6 +484,10 @@ void(string chaptertitle, string location, string date, string person, entity wh
 
 void (float achievement_id, optional entity who) GiveAchievement =
 {
+	return;
+
+	// Achievements have been removed, adding back TBD
+#if 0
 #ifndef FTE
 
 	// temp
@@ -495,41 +499,16 @@ void (float achievement_id, optional entity who) GiveAchievement =
 	// this is an achievement specific to an individual
 	if ((who && who != world) || player_count == 1) {
 		if (player_count == 1) who = find(world, classname, "player");
-
-#ifndef FTE
-
-		achievement(who, achievement_id);
-
-#else
-
-		WriteByte(MSG_MULTICAST, SVC_CGAMEPACKET);
-		WriteByte(MSG_MULTICAST, CSQC_EVENT_GIVEACHIEVEMENT);
-		WriteByte(MSG_MULTICAST, achievement_id);
-		msg_entity = who;
-		multicast('0 0 0', MULTICAST_ONE);
-
-#endif // FTE
-
+		nzp_achievement(who, achievement_id);
 	} else {
-
-#ifndef FTE
-
 		entity players;
 		players = find(world, classname, "player");
 		while(players != world) {
-			achievement(players, achievement_id);
+			nzp_achievement(players, achievement_id);
 			players = find(players, classname, "player");
 		}
-
-#else
-
-		WriteByte(MSG_MULTICAST, SVC_CGAMEPACKET);
-		WriteByte(MSG_MULTICAST, CSQC_EVENT_GIVEACHIEVEMENT);
-		WriteByte(MSG_MULTICAST, achievement_id);
-		multicast('0 0 0', MULTICAST_ALL);
-
-#endif // FTE
 	}
+#endif
 }
 
 #ifdef FTE

source/server/defs/standard.qc

@@ -233,7 +233,7 @@ string  (string s)
 string  (string s)                                                                              precache_sound2     = #76;  // registered version only
 string  (string s)                                                                              precache_file2      = #77;  // registered version only
 void    (entity e)                                                                              setspawnparms       = #78;  // set parm1... to the
-void    (entity plr, float achievement)                                                         achievement         = #79;
+void    (entity client, float achievement_id)                                                   nzp_achievement     = #79;
 float   (string s)                                                                              stof                = #81;  // 2001-09-20 QuakeC string manipulation by FrikaC
 //void	(vector where, float set)																multicast			= #82;
 vector  (entity what)                                                                           Get_Waypoint_Near   = #83;

source/server/fte_builtins.qc

@@ -0,0 +1,66 @@
+/*
+	server/fte_builtins.qc
+
+	FTE Implementation of Vril-Engine prog builtins
+
+	Copyright (C) 2021-2025 NZ:P Team
+
+	This program is free software; you can redistribute it and/or
+	modify it under the terms of the GNU General Public License
+	as published by the Free Software Foundation; either version 2
+	of the License, or (at your option) any later version.
+
+	This program is distributed in the hope that it will be useful,
+	but WITHOUT ANY WARRANTY; without even the implied warranty of
+	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+
+	See the GNU General Public License for more details.
+
+	You should have received a copy of the GNU General Public License
+	along with this program; if not, write to:
+
+		Free Software Foundation, Inc.
+		59 Temple Place - Suite 330
+		Boston, MA  02111-1307, USA
+
+*/
+#ifdef FTE
+
+//
+// NUM_FOR_EDICT(edict)
+// Accurate reimplementation of Vril
+// NUM_FOR_EDICT with edict_num acting
+// as a guard.
+//
+float NUM_FOR_EDICT(entity edict)
+{
+    float entnum = num_for_edict(edict);
+    edict_num(entnum);
+
+    return entnum;
+}
+
+//
+// nzp_achievement(client, achievement_id)
+// Awards achievement by sending approval to client.
+//
+void(entity client, float achievement_id) nzp_achievement =
+{
+    float entnum;
+    entnum = NUM_FOR_EDICT(client);
+
+    if (entnum < 1 || entnum > cvar("maxclients")) {
+        if (cvar("developer")) {
+            print("tried to unlock ach to a non-client\n");
+            return;
+        }
+    }
+
+    WriteByte(MSG_MULTICAST, SVC_CGAMEPACKET);
+	WriteByte(MSG_MULTICAST, CSQC_EVENT_GIVEACHIEVEMENT);
+	WriteByte(MSG_MULTICAST, achievement_id);
+	msg_entity = client;
+	multicast('0 0 0', MULTICAST_ONE);
+};
+
+#endif // FTE