Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: various changes to the github pipeline #96

Merged
merged 2 commits into from
Feb 24, 2025
Merged

ci: various changes to the github pipeline #96

merged 2 commits into from
Feb 24, 2025

Conversation

dupondje
Copy link
Member

@dupondje dupondje self-assigned this Feb 21, 2025
- don't run the container/pipeline as build user anymore.
actions/upload-artifact is broken under non-root user:
actions/upload-artifact#542

- fix libvirt under cgroupsv2 by adding --cgroupns host
moby/moby#42275

- start libvirtd and virtlogd
We need to start libvirtd and virtlogd in order to make virt-install
working inside the container.

- checkout
use actions/checkout as the workaround is not needed anymore as we run
as root anyway

- logs
Append os name to the logs so we don't have duplicate artifacts.

Signed-off-by: Jean-Louis Dupond <[email protected]>
Add storage image builds to the pipeline and set storage REPO to
9-stream.

Signed-off-by: Jean-Louis Dupond <[email protected]>
@dupondje
Copy link
Member Author

/build

Copy link

@JasperB-TeamBlue JasperB-TeamBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, build runs cleanly.

@dupondje dupondje merged commit b6875ee into master Feb 24, 2025
1 check passed
@dupondje dupondje deleted the ci_debug branch February 24, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants