Skip to content

Commit 71b9c6d

Browse files
committed
spec: drop buildrequires on rpmlint
rpmlint is only used in the CI, not during rpm build. So drop rpmlint as buildrequires in the spec and manually install it during the CI run. Signed-off-by: Jean-Louis Dupond <jean-louis@dupond.be>
1 parent 1a271b8 commit 71b9c6d

3 files changed

Lines changed: 11 additions & 1 deletion

File tree

.github/workflows/build-master.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ jobs:
3434
rpm -q --quiet ovirt-engine-nodejs-modules && ACTION=upgrade || ACTION=install
3535
dnf -y $ACTION ovirt-engine-nodejs-modules
3636
37+
- name: Install EPEL (for rpmlint on el10) and rpmlint
38+
run: |
39+
dnf -y install epel-release
40+
dnf -y install rpmlint
41+
3742
- name: Checkout sources
3843
uses: ovirt/checkout-action@main
3944

.github/workflows/check.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,12 @@ jobs:
3131
steps:
3232
- name: Mark git repo as safe
3333
run: git config --global --add safe.directory $(pwd)
34+
35+
- name: Install EPEL (for rpmlint on el10) and rpmlint
36+
run: |
37+
dnf -y install epel-release
38+
dnf -y install rpmlint
39+
3440
- name: Ensure latest ovirt-engine-nodejs-modules is installed
3541
run: |
3642
rpm -q --quiet ovirt-engine-nodejs-modules && ACTION=upgrade || ACTION=install

packaging/spec.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ BuildArch: noarch
1717
# requirements for packaging/build.sh (to be included in the build container)
1818
BuildRequires: git
1919
BuildRequires: jq
20-
BuildRequires: rpmlint
2120
BuildRequires: rpm-build
2221

2322
%if %{with ovirt_use_nodejs_modules}

0 commit comments

Comments
 (0)