Skip to content

Commit fbd2aba

Browse files
Core 4429 pdf redo (#778)
* update dataset text * CORE-4429 open pdf in new tab
1 parent 00d9cdd commit fbd2aba

File tree

14 files changed

+3934
-30959
lines changed

14 files changed

+3934
-30959
lines changed

components/markdown.jsx

+3-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ import Link from './link'
99
// pure text but renders own TextRenderer componet instead
1010
const MarkdownLink = ({ href, title, children }) => (
1111
<Link href={href} passHref>
12-
<a title={title}>{children}</a>
12+
<a target={href.includes('.pdf') ? '_blank' : '_self'} title={title}>
13+
{children}
14+
</a>
1315
</Link>
1416
)
1517

components/outreach-materials/index.jsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const format2name = (type) =>
2323
}[type])
2424

2525
const format2action = (type) =>
26-
['gdoc', 'gslides'].includes(type) ? 'Open' : 'Download'
26+
['gdoc', 'gslides', 'pdf'].includes(type) ? 'Open' : 'Download'
2727

2828
const ResourceLink = ({
2929
id,
@@ -51,6 +51,7 @@ const ResourceLink = ({
5151
data-format={format.toLowerCase()}
5252
data-action={action}
5353
data-label={label}
54+
target="_blank"
5455
{...props}
5556
{...restProps}
5657
>

data/faq.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -443,10 +443,10 @@ sections:
443443
question: |
444444
Can I use the CORE API for commercial purposes?
445445
answer: |
446-
Yes, you can use the CORE API for commercial purposes, (Terms & Conditions) apply.
447-
We provide 30 Day Free Trial for Institution and Enterprise.
448-
We will ask you for your circumstances during the registration process and we might
449-
contact you afterwards to clarify any points and assess your eligibility for a free licence.
446+
Yes, you can use the CORE API for commercial purposes, (Terms & Conditions) apply.
447+
We provide 30 Day Free Trial for Institution and Enterprise.
448+
We will ask you for your circumstances during the registration process and we might
449+
contact you afterwards to clarify any points and assess your eligibility for a free licence.
450450
If your circumstances change, please let us know.
451451
- slug: can-I-use-the-CORE-dataset-for-commercial-purposes
452452
question: |

data/membership.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ header:
1010
- caption: download our flyer
1111
url: /resources/core-leaflet-Glasgow-A3.pdf
1212
variant: text
13-
download: true
13+
target: _blank
1414

1515
content:
1616
- &dashboard

data/services/api.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ header:
1717
- caption: Download our flyer
1818
variant: text
1919
url: /resources/core-api-flyer.pdf
20-
download: true
20+
target: _blank
2121

2222

2323
features:

data/services/dataset.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ header:
1616
- caption: Download our flyer
1717
variant: text
1818
url: /resources/core-dataset-flyer.pdf
19-
download: true
19+
target: _blank
2020

2121
features:
2222
- title: All the data in one single place

data/services/fastsync.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ header:
1717
- caption: Download our flyer
1818
variant: text
1919
url: /resources/core-api-flyer.pdf
20-
download: true
20+
target: _blank
2121

2222

2323
features:

data/services/recommender.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ header:
2121
- caption: Download our flyer
2222
variant: text
2323
url: /resources/core_flyer_recomender.pdf
24-
download: true
24+
target: _blank
2525

2626

2727

data/sponsorship.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ header:
99
- caption: download our flyer
1010
url: /resources/flyer-CORE-Sponsorship.pdf
1111
variant: text
12-
download: true
12+
target: _blank
1313

1414
content:
1515
- &website

design-v2/components/hero/index.jsx

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const Hero = ({
3333
{actions.map((action) => (
3434
<Button
3535
href={action.url}
36+
target={action.target}
3637
variant={action.variant}
3738
key={action.caption}
3839
download={action.download}

0 commit comments

Comments
 (0)