fix: don't return true for isNode() under Deno

char · char · commit 10e8871d6f43 · 2025-07-02T22:19:28.000+01:00
as of Deno 2.4, the 'process' and 'global' variables are set in the
global environment, so it's better to explciitly exclude it now
diff --git a/utils/type_guards.ts b/utils/type_guards.ts
@@ -41,7 +41,8 @@ export function isNetAddr(value: unknown): value is NetAddr {
 
 export function isNode(): boolean {
   return "process" in globalThis && "global" in globalThis &&
-    !("Bun" in globalThis) && !("WebSocketPair" in globalThis);
+    !("Bun" in globalThis) && !("WebSocketPair" in globalThis) &&
+    !("Deno" in globalThis);
 }
 
 export function isFsFile(value: unknown): value is Deno.FsFile {

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,8 @@ export function isNetAddr(value: unknown): value is NetAddr {`
`41`	`41`
`42`	`42`	`export function isNode(): boolean {`
`43`	`43`	`return "process" in globalThis && "global" in globalThis &&`
`44`		`- !("Bun" in globalThis) && !("WebSocketPair" in globalThis);`
	`44`	`+ !("Bun" in globalThis) && !("WebSocketPair" in globalThis) &&`
	`45`	`+ !("Deno" in globalThis);`
`45`	`46`	`}`
`46`	`47`
`47`	`48`	`export function isFsFile(value: unknown): value is Deno.FsFile {`