fix: update for Uint8Array being generic

Author: dsherret

body.ts

@@ -9,7 +9,7 @@
  */
 
 import { createHttpError, matches, parseFormData, Status } from "./deps.ts";
-import type { ServerRequest } from "./types.ts";
+import type { ServerRequest, Uint8ArrayArrayBuffer } from "./types.ts";
 
 type JsonReviver = (key: string, value: unknown) => unknown;
 
@@ -30,13 +30,13 @@ const KNOWN_BODY_TYPES: [bodyType: BodyType, knownMediaTypes: string[]][] = [
 ];
 
 async function readBlob(
-  body?: ReadableStream<Uint8Array<ArrayBuffer>> | null,
+  body?: ReadableStream<Uint8ArrayArrayBuffer> | null,
   type?: string | null,
 ): Promise<Blob> {
   if (!body) {
     return new Blob(undefined, type ? { type } : undefined);
   }
-  const chunks: Uint8Array<ArrayBuffer>[] = [];
+  const chunks: Uint8ArrayArrayBuffer[] = [];
   for await (const chunk of body) {
     chunks.push(chunk);
   }
@@ -45,7 +45,7 @@ async function readBlob(
 
 /** An object which encapsulates information around a request body. */
 export class Body {
-  #body?: ReadableStream<Uint8Array<ArrayBuffer>> | null;
+  #body?: ReadableStream<Uint8ArrayArrayBuffer> | null;
   #memo: Promise<ArrayBuffer | Blob | FormData | string> | null = null;
   #memoType: "arrayBuffer" | "blob" | "formData" | "text" | null = null;
   #headers?: Headers;
@@ -80,7 +80,7 @@ export class Body {
   }
 
   /** Exposes the "raw" `ReadableStream` of the body. */
-  get stream(): ReadableStream<Uint8Array<ArrayBuffer>> | null {
+  get stream(): ReadableStream<Uint8ArrayArrayBuffer> | null {
     return this.#request ? this.#request.body : this.#body!;
   }
 

http_server_bun.ts

@@ -13,6 +13,7 @@ import type {
   ServeOptions,
   ServerRequest,
   ServeTlsOptions,
+  Uint8ArrayArrayBuffer,
 } from "./types.ts";
 import { createPromiseWithResolvers } from "./utils/create_promise_with_resolvers.ts";
 
@@ -94,7 +95,7 @@ class BunRequest implements ServerRequest {
   #resolved = false;
   #promise: Promise<Response>;
 
-  get body(): ReadableStream<Uint8Array<ArrayBuffer>> | null {
+  get body(): ReadableStream<Uint8ArrayArrayBuffer> | null {
     return this.#request.body;
   }
 
@@ -150,7 +151,7 @@ class BunRequest implements ServerRequest {
     this.#reject(reason);
   }
 
-  getBody(): ReadableStream<Uint8Array<ArrayBuffer>> | null {
+  getBody(): ReadableStream<Uint8ArrayArrayBuffer> | null {
     return this.#request.body;
   }
 

http_server_native_request.ts

@@ -3,6 +3,7 @@
 import type {
   NetAddr,
   ServerRequest,
+  Uint8ArrayArrayBuffer,
   UpgradeWebSocketFn,
   UpgradeWebSocketOptions,
 } from "./types.ts";
@@ -55,7 +56,7 @@ export class NativeRequest implements ServerRequest {
     this.#response = promise;
   }
 
-  get body(): ReadableStream<Uint8Array<ArrayBuffer>> | null {
+  get body(): ReadableStream<Uint8ArrayArrayBuffer> | null {
     return this.#request.body;
   }
 
@@ -102,7 +103,7 @@ export class NativeRequest implements ServerRequest {
     this.#resolved = true;
   }
 
-  getBody(): ReadableStream<Uint8Array<ArrayBuffer>> | null {
+  getBody(): ReadableStream<Uint8ArrayArrayBuffer> | null {
     return this.#request.body;
   }
 

http_server_node.ts

@@ -12,6 +12,7 @@ import type {
   ServeOptions,
   ServerRequest,
   ServeTlsOptions,
+  Uint8ArrayArrayBuffer,
 } from "./types.ts";
 import { createPromiseWithResolvers } from "./utils/create_promise_with_resolvers.ts";
 
@@ -90,15 +91,15 @@ export class NodeRequest implements ServerRequest {
     this.#responded = true;
   }
 
-  getBody(): ReadableStream<Uint8Array<ArrayBuffer>> | null {
-    let body: ReadableStream<Uint8Array<ArrayBuffer>> | null;
+  getBody(): ReadableStream<Uint8ArrayArrayBuffer> | null {
+    let body: ReadableStream<Uint8ArrayArrayBuffer> | null;
     if (this.method === "GET" || this.method === "HEAD") {
       body = null;
     } else {
-      body = new ReadableStream<Uint8Array<ArrayBuffer>>({
+      body = new ReadableStream<Uint8ArrayArrayBuffer>({
         start: (controller) => {
           this.#request.on("data", (chunk) => {
-            controller.enqueue(chunk as Uint8Array<ArrayBuffer>);
+            controller.enqueue(chunk as Uint8ArrayArrayBuffer);
           });
           this.#request.on("error", (err: Error) => {
             controller.error(err);

send.ts

@@ -31,6 +31,7 @@ import type { Response } from "./response.ts";
 import { isNode } from "./utils/type_guards.ts";
 import { decode } from "./utils/decode.ts";
 import { resolvePath } from "./utils/resolve_path.ts";
+import type { Uint8ArrayArrayBuffer } from "./types.ts";
 
 if (isNode()) {
   console.warn("oak send() does not work under Node.js.");
@@ -137,9 +138,15 @@ async function getEntity(
   stats: Deno.FileInfo,
   maxbuffer: number,
   response: Response,
-): Promise<[Uint8Array<ArrayBuffer> | Deno.FsFile, Uint8Array<ArrayBuffer> | FileInfo, FileInfo]> {
-  let body: Uint8Array<ArrayBuffer> | Deno.FsFile;
-  let entity: Uint8Array<ArrayBuffer> | FileInfo;
+): Promise<
+  [
+    Uint8ArrayArrayBuffer | Deno.FsFile,
+    Uint8ArrayArrayBuffer | FileInfo,
+    FileInfo,
+  ]
+> {
+  let body: Uint8ArrayArrayBuffer | Deno.FsFile;
+  let entity: Uint8ArrayArrayBuffer | FileInfo;
   const fileInfo = { mtime: new Date(mtime), size: stats.size };
   if (stats.size < maxbuffer) {
     const buffer = await Deno.readFile(path);
@@ -270,8 +277,8 @@ export async function send(
       : contentTypes[extname(path)] ?? extname(path);
   }
 
-  let entity: Uint8Array<ArrayBuffer> | FileInfo | null = null;
-  let body: Uint8Array<ArrayBuffer> | Deno.FsFile | null = null;
+  let entity: Uint8ArrayArrayBuffer | FileInfo | null = null;
+  let body: Uint8ArrayArrayBuffer | Deno.FsFile | null = null;
   let fileInfo: FileInfo | null = null;
 
   if (request.headers.has("If-None-Match") && mtime) {

types.ts

@@ -21,7 +21,7 @@ export interface ServerRequest {
   readonly url: string;
   // deno-lint-ignore no-explicit-any
   error(reason?: any): void;
-  getBody(): ReadableStream<Uint8Array<ArrayBuffer>> | null;
+  getBody(): ReadableStream<Uint8ArrayArrayBuffer> | null;
   respond(response: Response): void | Promise<void>;
   upgrade?(options?: UpgradeWebSocketOptions): WebSocket;
 }
@@ -38,8 +38,11 @@ export interface ServerConstructor<T extends ServerRequest> {
   type?: "native" | "node" | "bun";
 }
 
-export type Data = string | number[] | ArrayBuffer | Uint8Array<ArrayBuffer>;
-export type Key = string | number[] | ArrayBuffer | Uint8Array<ArrayBuffer>;
+/** Type for backwards compatibility. Resolves to `Uint8Array<ArrayBuffer>` in
+ * TypeScript 5.7+ and `Uint8Array` in older versions. */
+export type Uint8ArrayArrayBuffer = ReturnType<Uint8Array["slice"]>;
+export type Data = string | number[] | ArrayBuffer | Uint8ArrayArrayBuffer;
+export type Key = string | number[] | ArrayBuffer | Uint8ArrayArrayBuffer;
 
 export interface UpgradeWebSocketOptions {
   protocol?: string;