Skip to content

Commit 4df804b

Browse files
authored
Merge pull request #58 from yue9944882/chore/converge-on-klog
Chore: Converge on klog logger
2 parents 4010419 + f2280da commit 4df804b

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

cmd/addon-manager/main.go

+5-7
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ import (
1515
"k8s.io/client-go/kubernetes"
1616
nativescheme "k8s.io/client-go/kubernetes/scheme"
1717
"k8s.io/klog/v2"
18+
"k8s.io/klog/v2/klogr"
1819
apiregistrationv1 "k8s.io/kube-aggregator/pkg/apis/apiregistration/v1"
1920
"open-cluster-management.io/addon-framework/pkg/addonmanager"
2021
addonv1alpha1 "open-cluster-management.io/api/addon/v1alpha1"
2122
ocmauthv1alpha1 "open-cluster-management.io/managed-serviceaccount/api/v1alpha1"
2223
ctrl "sigs.k8s.io/controller-runtime"
23-
"sigs.k8s.io/controller-runtime/pkg/log/zap"
2424
)
2525

2626
var (
@@ -42,21 +42,19 @@ func main() {
4242
var probeAddr string
4343
var signerSecretName string
4444

45+
logger := klogr.New()
4546
klog.SetOutput(os.Stdout)
47+
klog.InitFlags(flag.CommandLine)
4648
flag.StringVar(&metricsAddr, "metrics-bind-address", ":48080", "The address the metric endpoint binds to.")
4749
flag.StringVar(&probeAddr, "health-probe-bind-address", ":48081", "The address the probe endpoint binds to.")
4850
flag.BoolVar(&enableLeaderElection, "leader-elect", false,
4951
"Enable leader election for controller manager. "+
5052
"Enabling this will ensure there is only one active controller manager.")
5153
flag.StringVar(&signerSecretName, "signer-secret-name", "cluster-gateway-signer",
5254
"The name of the secret to store the signer CA")
53-
opts := zap.Options{
54-
Development: true,
55-
}
56-
opts.BindFlags(flag.CommandLine)
57-
flag.Parse()
5855

59-
ctrl.SetLogger(zap.New(zap.UseFlagOptions(&opts)))
56+
flag.Parse()
57+
ctrl.SetLogger(logger)
6058

6159
mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
6260
Scheme: scheme,

cmd/apiserver/main.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import (
1919
"github.com/oam-dev/cluster-gateway/pkg/metrics"
2020
"github.com/oam-dev/cluster-gateway/pkg/options"
2121

22-
"k8s.io/klog"
22+
"k8s.io/klog/v2"
2323
"sigs.k8s.io/apiserver-runtime/pkg/builder"
2424

2525
// +kubebuilder:scaffold:resource-imports

pkg/apis/cluster/v1alpha1/zz_generated.deepcopy.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/proxy/v1alpha1/zz_generated.deepcopy.go

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)