Skip to content

Commit 2c10552

Browse files
r0x0dbocekm
authored andcommitted
Apply suggestions from code review
Co-authored-by: Michal Bocek <mbocek@redhat.com>
1 parent dafb3db commit 2c10552

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

convert2rhel/repo.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,19 +63,20 @@ def get_rhel_repos_to_disable():
6363
Avoid downloading backup and up-to-date checks from them. The output list can looks like: ["rhel*"]
6464
6565
.. note::
66-
If --enablerepo switch is enabled, we will return a combination of repositories to disable as following:
66+
If --enablerepo switch is used together with the --no-rhsm, we will return a combination of repositories to disable as following:
6767
6868
>>> # tool_opts.enablerepo comes from the CLI option `--enablerepo`.
6969
>>> repos_to_disable = ["rhel*"]
70-
>>> repos_to_disable.extend(tool_opts.enablerepo) # returns: ["rhel*", "rhel-7-server-optional-rpms"]
70+
>>> repos_to_disable.extend(tool_opts.enablerepo) # returns: ["rhel*", "my-rhel-repo-mirror"]
7171
7272
:return: List of repositories to disable when performing checks.
7373
:rtype: list[str]
7474
"""
7575
# RHELC-884 disable the RHEL repos to avoid reaching them when checking original system.
7676
repos_to_disable = ["rhel*"]
7777

78-
# In case we want to disable also the custom repositories set by the user in CLI
78+
# this is for the case where the user configures e.g. [my-rhel-repo-mirror] on the system and leaves it enabled
79+
# before running convert2rhel - we want to prevent the checks from accessing it as it contains packages for RHEL
7980
if tool_opts.no_rhsm:
8081
repos_to_disable.extend(tool_opts.enablerepo)
8182

0 commit comments

Comments
 (0)