Skip to content

Commit a0e638c

Browse files
committed
Handle multipath configs during TargetTransactionFactsChecksTag
The target_uspace_configs and multipath_upgrade_conf_patcher actors were originally executed during the ChecksPhase. However, as they need to access the system storage, we do not want to keep them part of the ChecksPhase at this moment. Moving them to TargetTransactionFactsChecksTag instead. I know this use is not aligned with the phase description, but we use it already even for other things as well, so let's go rather this way this time.
1 parent 892a729 commit a0e638c

File tree

2 files changed

+4
-4
lines changed
  • repos/system_upgrade
    • common/actors/multipath/target_uspace_configs
    • el8toel9/actors/multipath_upgrade_conf_patcher

2 files changed

+4
-4
lines changed

repos/system_upgrade/common/actors/multipath/target_uspace_configs/actor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from leapp.actors import Actor
22
from leapp.libraries.actor import target_uspace_multipath_configs
33
from leapp.models import MultipathConfigUpdatesInfo, MultipathInfo, TargetUserSpaceUpgradeTasks, UpgradeInitramfsTasks
4-
from leapp.tags import ChecksPhaseTag, IPUWorkflowTag
4+
from leapp.tags import IPUWorkflowTag, TargetTransactionChecksPhaseTag
55

66

77
class RequestMultipathConfsInTargetUserspace(Actor):
@@ -16,7 +16,7 @@ class RequestMultipathConfsInTargetUserspace(Actor):
1616
name = 'request_multipath_conf_in_target_userspace'
1717
consumes = (MultipathInfo, MultipathConfigUpdatesInfo)
1818
produces = (TargetUserSpaceUpgradeTasks, UpgradeInitramfsTasks)
19-
tags = (ChecksPhaseTag, IPUWorkflowTag)
19+
tags = (TargetTransactionChecksPhaseTag, IPUWorkflowTag)
2020

2121
def process(self):
2222
target_uspace_multipath_configs.process()

repos/system_upgrade/el8toel9/actors/multipath_upgrade_conf_patcher/actor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from leapp.actors import Actor
22
from leapp.libraries.actor import multipathconfupdate
33
from leapp.models import MultipathConfFacts8to9, MultipathConfigUpdatesInfo
4-
from leapp.tags import ChecksPhaseTag, IPUWorkflowTag
4+
from leapp.tags import IPUWorkflowTag, TargetTransactionChecksPhaseTag
55

66

77
class MultipathUpgradeConfUpdate8to9(Actor):
@@ -16,7 +16,7 @@ class MultipathUpgradeConfUpdate8to9(Actor):
1616
name = 'multipath_upgrade_conf_update_8to9'
1717
consumes = (MultipathConfFacts8to9,)
1818
produces = (MultipathConfigUpdatesInfo,)
19-
tags = (ChecksPhaseTag, IPUWorkflowTag)
19+
tags = (TargetTransactionChecksPhaseTag, IPUWorkflowTag)
2020

2121
def process(self):
2222
facts = next(self.consume(MultipathConfFacts8to9), None)

0 commit comments

Comments
 (0)