Skip to content

Commit deeccac

Browse files
committed
Extend the compatibility-with-leapp-repository.html
Include real life scenario how to cross-reference leapp/leapp-repository dependencies in spec files from a leapp dev POV.
1 parent c7b7897 commit deeccac

1 file changed

Lines changed: 16 additions & 1 deletion

File tree

docs/source/compatibility-with-leapp-repository.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ when we agree it's worthwhile.
1010

1111
But we need a mechanism to be able to synchronize with other projects, when we
1212
provide new functionality in the upstream (master) branch without the need
13-
of immadiate release of the new version of leapp. For these purposes the
13+
of immediate release of the new version of leapp. For these purposes the
1414
`leapp-framework` capability is provided in the framework (python[23]-leapp) rpms.
1515

16+
1617
## When and how change the capability
1718

1819
The `leapp-framework` capability has to be changed in case of any change of
@@ -57,3 +58,17 @@ on the system, you could end up with:
5758
which both are broken for leapp repository and the dependency from the point of
5859
rpms is satisfied. This should happen rarely. We suggest you to ensure that you
5960
use such repositories where only one of those rpms exists.
61+
62+
63+
# Leapp developer's point of view
64+
65+
Some big and cool feature requests require changes to land in both leapp and leapp-repository projects simultaneously.
66+
To instruct how to pick up the proper version, you need to make changes to the spec files that reside in the
67+
`packaging` directory of both projects.
68+
69+
For example, let's say that [packaging/leapp.spec](./packaging/leapp.spec#L16) has `framework_version 42.42` and
70+
the cool change you are working on is breaking previous functionality.
71+
72+
In leapp PR you would need to bump the version in the spec file to `framework_version 43.0`.
73+
In leapp-repository PR you would then need to address the expected version by adjusting the Requires directive,
74+
like `Requires: leapp-framework >= 43.0, leapp-framework < 44`

0 commit comments

Comments
 (0)