♻️ Refactor test requires for proper load order

Author: pboling

test/helper.rb

@@ -0,0 +1,7 @@
+require "logger"
+
+module TestLogging
+  LOGGER = Logger.new($stdout)
+end
+
+TestLogging::LOGGER.level = Logger::WARN

test/support/logging.rb

@@ -1,5 +1,14 @@
 # External dependencies
 require "byebug" if ENV.fetch("DEBUG", "false").casecmp?("true")
+require "net/http"
+require "rack"
+require "rack/session"
+
+# testing libraries
+require "minitest/rg"
+
+# Test support
+require "support/logging"
 
 ## Last thing before loading this gem is to setup code coverage
 begin
@@ -11,12 +20,11 @@
   nil
 end
 
-# Testing libraries
+# Testing libraries that need to load after simplecov
 require "minitest/autorun"
-require "minitest/rg"
-require "net/http"
-require "rack"
-require "rack/session"
 
 # Internal dependencies & mixins
-require_relative "helper"
+require "rack/openid"
+require "rack/openid/simple_auth"
+
+OpenID::Util.logger = TestLogging::LOGGER

test/test_helper.rb

@@ -1,3 +1,6 @@
+# External libraries
+require "rots"
+
 require_relative "test_helper"
 
 describe "integration" do
@@ -30,8 +33,6 @@ def fetch(url, body = nil, headers = nil, limit = nil)
   ROTS_SERVER_URL = "http://localhost:9292"
 
   RotsApp = Rack::Builder.new do
-    require "rots"
-
     config = {
       "identity" => "john.doe",
       "sreg" => {