Fix starting a queue on a specific node

The `:node` option was incorrectly preserved when starting a queue,
which would crash it. Now the `:node` is dropped after scoping the start
signal.

Closes #1382

Author: sorentwo

lib/oban.ex

@@ -954,14 +954,15 @@ defmodule Oban do
   def start_queue(name \\ __MODULE__, [_ | _] = opts) do
     conf = config(name)
 
-    validate_queue_opts!(opts, ~w(local_only queue)a)
+    validate_queue_opts!(opts, ~w(local_only node queue)a)
     validate_engine_meta!(conf, opts)
 
     data =
       opts
       |> Map.new()
       |> Map.put(:action, :start)
       |> Map.put(:ident, scope_signal(conf, opts))
+      |> Map.drop([:node])
 
     Notifier.notify(conf, :signal, data)
   end

test/oban_test.exs

@@ -486,7 +486,7 @@ defmodule ObanTest do
       assert_invalid_opts(name, :start_queue, wat: -1)
     end
 
-    test "starting individual queues dynamically" do
+    test "starting queues dynamically" do
       name = start_supervised_oban!(queues: [alpha: 9])
 
       assert :ok = Oban.start_queue(name, queue: :gamma, limit: 5, refresh_interval: 10)
@@ -500,7 +500,7 @@ defmodule ObanTest do
       end)
     end
 
-    test "starting individual queues only on the local node" do
+    test "starting queues only on the local node" do
       name1 = start_supervised_oban!(queues: [])
       name2 = start_supervised_oban!(queues: [])
 
@@ -511,6 +511,18 @@ defmodule ObanTest do
         refute supervised_queue?(name2, "alpha")
       end)
     end
+
+    test "starting queues on a specific node" do
+      name1 = start_supervised_oban!(node: "worker.1", queues: [])
+      name2 = start_supervised_oban!(node: "worker.2", queues: [])
+
+      assert :ok = Oban.start_queue(name1, queue: :alpha, limit: 1, node: "worker.1")
+
+      with_backoff(fn ->
+        assert supervised_queue?(name1, "alpha")
+        refute supervised_queue?(name2, "alpha")
+      end)
+    end
   end
 
   describe "stop_queue/2" do