Skip to content

Commit a25e62e

Browse files
committed
Remove sidebar from queues page The sidebar filters (paused, terminating, modes, nodes) added little
The sidebar filters (paused, terminating, modes, nodes) added little value for a typically small dataset while consuming significant screen space. Filtering remains available via the search component.
1 parent 3708346 commit a25e62e

File tree

3 files changed

+4
-77
lines changed

3 files changed

+4
-77
lines changed

lib/oban/web/live/queues/sidebar_component.ex

Lines changed: 0 additions & 63 deletions
This file was deleted.

lib/oban/web/pages/queues_page.ex

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,24 +5,16 @@ defmodule Oban.Web.QueuesPage do
55

66
alias Oban.Met
77

8-
alias Oban.Web.Queues.{DetailComponent, DetailInsanceComponent}
9-
alias Oban.Web.Queues.{SidebarComponent, TableComponent}
8+
alias Oban.Web.Queues.{DetailComponent, DetailInsanceComponent, TableComponent}
109
alias Oban.Web.{Page, QueueQuery, SearchComponent, SortComponent, Telemetry}
1110

1211
@known_params ~w(modes nodes sort_by sort_dir stats)
1312

1413
@impl Phoenix.LiveComponent
1514
def render(assigns) do
1615
~H"""
17-
<div id="queues-page" class="w-full flex flex-col my-6 md:flex-row">
18-
<SidebarComponent.sidebar
19-
queues={@queues}
20-
params={without_defaults(@params, @default_params)}
21-
width={@sidebar_width}
22-
csp_nonces={@csp_nonces}
23-
/>
24-
25-
<div class="flex-grow">
16+
<div id="queues-page" class="w-full my-6">
17+
<div>
2618
<div class="bg-white dark:bg-gray-900 rounded-md shadow-lg overflow-hidden">
2719
<%= if @detail do %>
2820
<.live_component

test/oban/web/pages/queues/index_test.exs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,7 @@ defmodule Oban.Web.Pages.Queues.IndexTest do
8181

8282
toggle_select_all(live)
8383

84-
live
85-
|> element("#sidebar #filter-paused")
86-
|> render_click()
84+
{:ok, live, _html} = live(build_conn(), "/oban/queues?stats=paused")
8785

8886
refute has_element?(live, "#queue-alpha")
8987
assert has_element?(live, "#queue-bravo")

0 commit comments

Comments
 (0)