fix: Allow underscore in SafeUrlPart

Author: tomasol

.envrc-example

@@ -9,6 +9,6 @@ export FLY_ORG_SLUG="personal"
 # App name: Either create fly.toml based on fly-example.toml and extract the app name, or just enter it here.
 export FLY_APP_NAME=$(grep '^app' fly.toml | sed -E 's/app *= *["'\'']([^"'\''"]+)["'\'']/\1/')
 
-export FLY_IMAGE="getobelisk/obelisk:0.24.1-ubuntu"
+export FLY_IMAGE="getobelisk/obelisk:0.25.1-ubuntu"
 export FLY_MACHINE_NAME="machine"
 export FLY_REGION="ams"

activity/fly-http/impl/src/lib.rs

@@ -31,14 +31,16 @@ struct SafeUrlPart<T> {
 }
 impl<T> SafeUrlPart<T> {
     fn new(s: String) -> Result<SafeUrlPart<T>, anyhow::Error> {
-        if s.chars().all(|c| c.is_ascii_alphanumeric() || c == '-') {
-            Ok(SafeUrlPart {
-                value: s,
-                _phantom_data: PhantomData,
-            })
-        } else {
-            bail!("illegal slug")
+        if let Some(illegal) = s
+            .chars()
+            .find(|c| !c.is_ascii_alphanumeric() && *c != '-' && *c != '_')
+        {
+            bail!("illegal character: {}", illegal);
         }
+        Ok(SafeUrlPart {
+            value: s,
+            _phantom_data: PhantomData,
+        })
     }
 }
 impl<T> AsRef<str> for SafeUrlPart<T> {