Skip to content

Commit 230be09

Browse files
authored
Merge pull request #665 from obeli-sk/fix-wit-deps-disable-webui
fix(cli): Disable WebUI in `generate wit-deps` to aviod panicing
2 parents 336d6da + 8cf254e commit 230be09

1 file changed

Lines changed: 10 additions & 9 deletions

File tree

src/command/generate.rs

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ use crate::command::termination_notifier::termination_notifier;
88
use crate::config::config_holder::{ConfigHolder, load_deployment_validated};
99
use crate::config::toml::{
1010
ActivityExternalComponentConfigToml, ActivityStubComponentConfigToml, ComponentLocationToml,
11-
DeploymentTomlValidated, JsLocationToml,
11+
DeploymentTomlValidated, JsLocationToml, ServerConfigToml,
1212
};
1313
use crate::init::{self};
1414
use crate::project_dirs;
@@ -575,10 +575,9 @@ async fn generate_wit_deps(
575575
load_deployment_validated(&deployment_toml).await?,
576576
skip_local,
577577
);
578-
579-
let config_holder = ConfigHolder::new(project_dirs, base_dirs, None)?;
580-
let config = config_holder.load_config().await?;
581-
let _guard = init::init(&config)?;
578+
let mut server_config = ServerConfigToml::default();
579+
server_config.webui.enabled = false;
580+
let _guard = init::init(&server_config)?; // Configure logging
582581
let deployment = deployment
583582
.canonicalize()
584583
.await
@@ -594,15 +593,17 @@ async fn generate_wit_deps(
594593
suppress_type_checking_errors: true, // Just extracting WITs, not running components
595594
suppress_linking_errors: true, // Just extracting WITs, not running components
596595
};
596+
597+
let config_holder = ConfigHolder::new(project_dirs, base_dirs, None)?;
597598
let prepared_dirs = prepare_dirs(
598-
&config,
599+
&server_config,
599600
&verify_params.dir_params,
600601
&config_holder.path_prefixes,
601602
)
602603
.await?;
603-
let engines = create_engines(&config, &prepared_dirs)?;
604+
let engines = create_engines(&server_config, &prepared_dirs)?;
604605

605-
let server_verified = Box::pin(server_verify(config, engines)).await?;
606+
let server_verified = Box::pin(server_verify(server_config, engines)).await?;
606607
let deployment_verified = deployment_verify_config(
607608
&server_verified,
608609
&prepared_dirs,
@@ -637,7 +638,7 @@ async fn generate_wit_deps(
637638
let mut synthesized_exports: Vec<PackageIfcFns> = Vec::new();
638639
for component in compiled_and_linked.component_registry_ro.list(true) {
639640
let Some(importable) = &component.workflow_or_activity_config else {
640-
unreachable!("webhooks and crons are filtered out");
641+
unreachable!("webhooks and crons are filtered out, found {component:?}");
641642
};
642643
match component.wit_origin {
643644
WitOrigin::Synthesized => {

0 commit comments

Comments
 (0)