Merge pull request #775 from obeli-sk/wit-execution-failure-kind

WIT major version bump: Rework execution ID passing, getting failure kind

Author: tomasol

assets/activity-js-runtime-version.txt

@@ -1 +1 @@
-oci://docker.io/getobelisk/activity-js-runtime:2026-06-09@sha256:5e4fe38ee3238707686079f1c83683042117f33db2455dc705fc912bf553c46c
+oci://docker.io/getobelisk/activity-js-runtime:2026-07-10@sha256:6d347784056d76376dcdcbbd26b66c0eb5ec56ccdc3d8c642df5c3994179eace

assets/webhook-js-runtime-version.txt

@@ -1 +1 @@
-oci://docker.io/getobelisk/webhook-js-runtime:2026-07-04@sha256:1b7f5d66b731ea2824e6ea656f6bbb98a0429c7342492dcc17c15648ba54b80b
+oci://docker.io/getobelisk/webhook-js-runtime:2026-07-10@sha256:bd0ef4d00c0f3f71e62905ba9fea161b66beb9e8ce10406a5f42008283317a7a

assets/workflow-js-runtime-version.txt

@@ -1 +1 @@
-oci://docker.io/getobelisk/workflow-js-runtime:2026-06-09@sha256:27d8b82f6457cede0448da30e977392e919e4abc17d93181d7f86901f30d42dc
+oci://docker.io/getobelisk/workflow-js-runtime:2026-07-10@sha256:9653ab166704bb6d7936aab023e058fcc017bbeaac97911b6d91a1646af9cde9

crates/testing/test-programs/fibo/activity/wit/gen/testing_fibo-obelisk-ext/testing_fibo-obelisk-ext.wit

@@ -1,14 +1,14 @@
-// Generated by Obelisk 0.31.0-dev
+// Generated by Obelisk 0.39.5
 package testing:fibo-obelisk-ext;
 
 interface fibo {
-  use obelisk:types/execution@4.2.0.{execution-id};
-  use obelisk:types/join-set@4.2.0.{join-set};
-  use obelisk:types/execution@4.2.0.{await-next-extension-error, get-extension-error};
+  use obelisk:types/execution@5.0.0.{execution-id};
+  use obelisk:types/join-set@5.0.0.{join-set};
+  use obelisk:types/execution@5.0.0.{await-next-extension-error, get-extension-error};
 
   fibo-submit: func(join-set: borrow<join-set>, n: u8) -> execution-id;
 
-  fibo-await-next: func(join-set: borrow<join-set>) -> result<tuple<execution-id, result<u64>>, await-next-extension-error>;
+  fibo-await-next: func(join-set: borrow<join-set>) -> result<result<u64>, await-next-extension-error>;
 
   fibo-get: func(execution-id: execution-id) -> result<result<u64>, get-extension-error>;
 }

crates/testing/test-programs/fibo/activity/wit/gen/testing_fibo-obelisk-schedule/testing_fibo-obelisk-schedule.wit

@@ -1,9 +1,9 @@
-// Generated by Obelisk 0.25.1
+// Generated by Obelisk 0.39.5
 package testing:fibo-obelisk-schedule;
 
 interface fibo {
-  use obelisk:types/execution@4.2.0.{execution-id};
-  use obelisk:types/time@4.2.0.{schedule-at};
+  use obelisk:types/execution@5.0.0.{execution-id};
+  use obelisk:types/time@5.0.0.{schedule-at};
 
   fibo-schedule: func(schedule-at: schedule-at, n: u8) -> execution-id;
 }

crates/testing/test-programs/fibo/workflow-outer/src/lib.rs

@@ -39,13 +39,13 @@ impl GuestNesting for Component {
         use generated::testing::fibo_workflow_obelisk_ext::workflow::{
             fiboa_concurrent_await_next, fiboa_concurrent_submit,
         };
-        let join_set = join_set_create();
+        let join_set = join_set_create(None);
         for _ in 0..fiboas {
             fiboa_concurrent_submit(&join_set, n, iterations_per_fiboa);
         }
         let mut last = 0;
         for _ in 0..fiboas {
-            last = fiboa_concurrent_await_next(&join_set).unwrap().1.unwrap();
+            last = fiboa_concurrent_await_next(&join_set).unwrap().unwrap();
         }
         Ok(last)
     }

crates/testing/test-programs/fibo/workflow-outer/wit/impl.wit

@@ -4,7 +4,7 @@ world any {
     export testing:fibo-workflow-outer/workflow;
 
     import obelisk:log/log@1.0.0;
-    import obelisk:workflow/workflow-support@5.1.0;
+    import obelisk:workflow/workflow-support@6.0.0;
 
     import testing:fibo-workflow/workflow;
     import testing:fibo-workflow-obelisk-ext/workflow;

crates/testing/test-programs/fibo/workflow/src/lib.rs

@@ -48,20 +48,20 @@ impl Guest for Component {
     }
 
     fn fiboa_concurrent(n: u8, iterations: u32) -> Result<u64, ()> {
-        let join_set = join_set_create();
+        let join_set = join_set_create(None);
         for _ in 0..iterations {
             fibo_submit(&join_set, n);
         }
         let mut last = 0;
         for _ in 0..iterations {
-            last = fibo_await_next(&join_set).unwrap().1.unwrap();
+            last = fibo_await_next(&join_set).unwrap().unwrap();
         }
         Ok(last)
     }
 
     fn fiboa_submit_json(n: u8) -> Result<u64, ()> {
         // Create a join set
-        let join_set = join_set_create();
+        let join_set = join_set_create(None);
 
         // Submit using JSON params - the fibo function takes a single u8 parameter
         let params_json = format!("[{n}]");
@@ -73,18 +73,20 @@ impl Guest for Component {
         let execution_id = submit_json(&join_set, &function, &params_json, None)
             .expect("submit_json should succeed");
 
-        // Await the result
-        let (response_id, is_success) = join_next(&join_set).expect("all-processed cannot happen");
-        let result_exec_id = assert_matches!(response_id, ResponseId::ExecutionId(exe) => exe);
+        // Await the result; the value is returned directly, the id via `last_id`.
+        let join_value = join_next(&join_set, None).expect("all-processed cannot happen");
+        let result_exec_id =
+            assert_matches!(join_set.last_id(), Some(ResponseId::ExecutionId(exe)) => exe);
         // Verify the execution IDs match
         assert_eq!(
             execution_id.id, result_exec_id.id,
             "execution IDs should match"
         );
-        assert!(is_success.is_ok());
+        assert!(join_value.is_ok());
 
         // Now get the result using get_result_json
-        let json_result = get_result_json(&execution_id).expect("get_result_json should succeed");
+        let json_result =
+            get_result_json(&execution_id, None).expect("get_result_json should succeed");
 
         // json_result is Result<Option<String>, Option<String>>
         // For fibo, we expect Ok(Some(json_string)) containing the u64 value
@@ -101,7 +103,7 @@ impl Guest for Component {
 
     /// Test submit-json with unknown FFQN → FunctionNotFound error.
     fn test_submit_json_unknown_ffqn() -> Result<(), String> {
-        let join_set = join_set_create();
+        let join_set = join_set_create(None);
         let function = Function {
             interface_name: "testing:nonexistent/ifc".to_string(),
             function_name: "unknown-fn".to_string(),
@@ -115,7 +117,7 @@ impl Guest for Component {
 
     /// Test submit-json with malformed JSON params → ParamsParsingError.
     fn test_submit_json_malformed_params() -> Result<(), String> {
-        let join_set = join_set_create();
+        let join_set = join_set_create(None);
         let function = Function {
             interface_name: "testing:fibo/fibo".to_string(),
             function_name: "fibo".to_string(),
@@ -159,7 +161,7 @@ impl Guest for Component {
 
     /// Test get-result-json before await → NotFoundInProcessedResponses.
     fn test_get_result_json_before_await() -> Result<(), String> {
-        let join_set = join_set_create();
+        let join_set = join_set_create(None);
         let function = Function {
             interface_name: "testing:fibo/fibo".to_string(),
             function_name: "fibo".to_string(),
@@ -170,7 +172,7 @@ impl Guest for Component {
             .map_err(|e| format!("submit_json failed: {e:?}"))?;
 
         // Try to get result before awaiting - should fail
-        match get_result_json(&execution_id) {
+        match get_result_json(&execution_id, None) {
             Err(GetResultJsonError::NotFoundInProcessedResponses) => Ok(()),
             Err(other) => Err(format!(
                 "expected NotFoundInProcessedResponses, got {other:?}"
@@ -181,7 +183,7 @@ impl Guest for Component {
 
     /// Test get-result-json when activity returns error variant → Err(None) since fibo returns result<u64>.
     fn test_get_result_json_err_variant() -> Result<(), String> {
-        let join_set = join_set_create();
+        let join_set = join_set_create(None);
         let function = Function {
             interface_name: "testing:fibo/fibo".to_string(),
             function_name: "fibo".to_string(),
@@ -191,9 +193,13 @@ impl Guest for Component {
         let execution_id = submit_json(&join_set, &function, "[50]", None)
             .map_err(|e| format!("submit_json failed: {e:?}"))?;
 
-        // Await the result using the typed extension function
-        let (result_exec_id, result) =
+        // Await the result using the typed extension function (value only; id via last_id).
+        let result =
             fibo_await_next(&join_set).map_err(|e| format!("fibo_await_next failed: {e:?}"))?;
+        let result_exec_id = match join_set.last_id() {
+            Some(ResponseId::ExecutionId(exe)) => exe,
+            other => return Err(format!("expected execution id from last_id, got {other:?}")),
+        };
 
         // Verify the execution IDs match
         if execution_id.id != result_exec_id.id {
@@ -209,8 +215,8 @@ impl Guest for Component {
         }
 
         // Now get the result using get_result_json
-        let json_result =
-            get_result_json(&execution_id).map_err(|e| format!("get_result_json failed: {e:?}"))?;
+        let json_result = get_result_json(&execution_id, None)
+            .map_err(|e| format!("get_result_json failed: {e:?}"))?;
 
         // json_result should be Err(None) since fibo returns result<u64> (error type is unit)
         match json_result {
@@ -229,30 +235,16 @@ impl Guest for Component {
 
         // Test 1: Schedule with ScheduleAt::Now
         let execution_id = execution_id_generate(None);
-        schedule_json(
-            &execution_id,
-            ScheduleAt::Now,
-            &function,
-            "[10]",
-            None,
-            None,
-        )
-        .map_err(|e| format!("schedule_json failed: {e:?}"))?;
+        schedule_json(&execution_id, ScheduleAt::Now, &function, "[10]", None)
+            .map_err(|e| format!("schedule_json failed: {e:?}"))?;
 
         // Test 2: Schedule with unknown FFQN -> FunctionNotFound
         let unknown_function = Function {
             interface_name: "testing:nonexistent/ifc".to_string(),
             function_name: "unknown-fn".to_string(),
         };
         let exec_id_2 = execution_id_generate(None);
-        match schedule_json(
-            &exec_id_2,
-            ScheduleAt::Now,
-            &unknown_function,
-            "[]",
-            None,
-            None,
-        ) {
+        match schedule_json(&exec_id_2, ScheduleAt::Now, &unknown_function, "[]", None) {
             Err(ScheduleJsonError::FunctionNotFound) => {}
             Err(other) => return Err(format!("2: expected FunctionNotFound, got {other:?}")),
             Ok(()) => return Err("2: expected error, got Ok".to_string()),
@@ -266,7 +258,6 @@ impl Guest for Component {
             &function,
             "not valid json",
             None,
-            None,
         ) {
             Err(ScheduleJsonError::TypeCheckError(msg)) => {
                 if !msg.contains("cannot parse params as JSON array") {
@@ -279,7 +270,7 @@ impl Guest for Component {
 
         // Test 4: Schedule with valid JSON but not an array
         let exec_id_4 = execution_id_generate(None);
-        match schedule_json(&exec_id_4, ScheduleAt::Now, &function, "42", None, None) {
+        match schedule_json(&exec_id_4, ScheduleAt::Now, &function, "42", None) {
             Err(ScheduleJsonError::TypeCheckError(msg)) => {
                 if msg.contains("4: params must be a json array") {
                     return Err(format!("4: unexpected error message: {msg}"));
@@ -291,7 +282,7 @@ impl Guest for Component {
 
         // Test 5: Schedule with valid JSON but not the expected types
         let exec_id_5 = execution_id_generate(None);
-        match schedule_json(&exec_id_5, ScheduleAt::Now, &function, r#"["42"]"#, None, None) {
+        match schedule_json(&exec_id_5, ScheduleAt::Now, &function, r#"["42"]"#, None) {
             Err(ScheduleJsonError::TypeCheckError(msg)) => {
                 if !msg.starts_with(
                     "params type checking failed: parameters cannot be deserialized: cannot parse 1-th parameter - \

crates/testing/test-programs/fibo/workflow/wit/gen/testing_fibo-workflow-obelisk-ext/testing_fibo-workflow-obelisk-ext.wit

@@ -1,62 +1,62 @@
-// Generated by Obelisk 0.35.4
+// Generated by Obelisk 0.39.5
 package testing:fibo-workflow-obelisk-ext;
 
 interface workflow {
-  use obelisk:types/execution@4.2.0.{execution-id};
-  use obelisk:types/join-set@4.2.0.{join-set};
-  use obelisk:types/execution@4.2.0.{await-next-extension-error, get-extension-error};
+  use obelisk:types/execution@5.0.0.{execution-id};
+  use obelisk:types/join-set@5.0.0.{join-set};
+  use obelisk:types/execution@5.0.0.{await-next-extension-error, get-extension-error};
 
   fibow-submit: func(join-set: borrow<join-set>, n: u8, iterations: u32) -> execution-id;
 
-  fibow-await-next: func(join-set: borrow<join-set>) -> result<tuple<execution-id, result<u64>>, await-next-extension-error>;
+  fibow-await-next: func(join-set: borrow<join-set>) -> result<result<u64>, await-next-extension-error>;
 
   fibow-get: func(execution-id: execution-id) -> result<result<u64>, get-extension-error>;
 
   fiboa-submit: func(join-set: borrow<join-set>, n: u8, iterations: u32) -> execution-id;
 
-  fiboa-await-next: func(join-set: borrow<join-set>) -> result<tuple<execution-id, result<u64>>, await-next-extension-error>;
+  fiboa-await-next: func(join-set: borrow<join-set>) -> result<result<u64>, await-next-extension-error>;
 
   fiboa-get: func(execution-id: execution-id) -> result<result<u64>, get-extension-error>;
 
   fiboa-concurrent-submit: func(join-set: borrow<join-set>, n: u8, iterations: u32) -> execution-id;
 
-  fiboa-concurrent-await-next: func(join-set: borrow<join-set>) -> result<tuple<execution-id, result<u64>>, await-next-extension-error>;
+  fiboa-concurrent-await-next: func(join-set: borrow<join-set>) -> result<result<u64>, await-next-extension-error>;
 
   fiboa-concurrent-get: func(execution-id: execution-id) -> result<result<u64>, get-extension-error>;
 
   fiboa-submit-json-submit: func(join-set: borrow<join-set>, n: u8) -> execution-id;
 
-  fiboa-submit-json-await-next: func(join-set: borrow<join-set>) -> result<tuple<execution-id, result<u64>>, await-next-extension-error>;
+  fiboa-submit-json-await-next: func(join-set: borrow<join-set>) -> result<result<u64>, await-next-extension-error>;
 
   fiboa-submit-json-get: func(execution-id: execution-id) -> result<result<u64>, get-extension-error>;
 
   test-submit-json-unknown-ffqn-submit: func(join-set: borrow<join-set>) -> execution-id;
 
-  test-submit-json-unknown-ffqn-await-next: func(join-set: borrow<join-set>) -> result<tuple<execution-id, result<_, string>>, await-next-extension-error>;
+  test-submit-json-unknown-ffqn-await-next: func(join-set: borrow<join-set>) -> result<result<_, string>, await-next-extension-error>;
 
   test-submit-json-unknown-ffqn-get: func(execution-id: execution-id) -> result<result<_, string>, get-extension-error>;
 
   test-submit-json-malformed-params-submit: func(join-set: borrow<join-set>) -> execution-id;
 
-  test-submit-json-malformed-params-await-next: func(join-set: borrow<join-set>) -> result<tuple<execution-id, result<_, string>>, await-next-extension-error>;
+  test-submit-json-malformed-params-await-next: func(join-set: borrow<join-set>) -> result<result<_, string>, await-next-extension-error>;
 
   test-submit-json-malformed-params-get: func(execution-id: execution-id) -> result<result<_, string>, get-extension-error>;
 
   test-get-result-json-before-await-submit: func(join-set: borrow<join-set>) -> execution-id;
 
-  test-get-result-json-before-await-await-next: func(join-set: borrow<join-set>) -> result<tuple<execution-id, result<_, string>>, await-next-extension-error>;
+  test-get-result-json-before-await-await-next: func(join-set: borrow<join-set>) -> result<result<_, string>, await-next-extension-error>;
 
   test-get-result-json-before-await-get: func(execution-id: execution-id) -> result<result<_, string>, get-extension-error>;
 
   test-get-result-json-err-variant-submit: func(join-set: borrow<join-set>) -> execution-id;
 
-  test-get-result-json-err-variant-await-next: func(join-set: borrow<join-set>) -> result<tuple<execution-id, result<_, string>>, await-next-extension-error>;
+  test-get-result-json-err-variant-await-next: func(join-set: borrow<join-set>) -> result<result<_, string>, await-next-extension-error>;
 
   test-get-result-json-err-variant-get: func(execution-id: execution-id) -> result<result<_, string>, get-extension-error>;
 
   test-schedule-json-submit: func(join-set: borrow<join-set>) -> execution-id;
 
-  test-schedule-json-await-next: func(join-set: borrow<join-set>) -> result<tuple<execution-id, result<execution-id, string>>, await-next-extension-error>;
+  test-schedule-json-await-next: func(join-set: borrow<join-set>) -> result<result<execution-id, string>, await-next-extension-error>;
 
   test-schedule-json-get: func(execution-id: execution-id) -> result<result<execution-id, string>, get-extension-error>;
 }

crates/testing/test-programs/fibo/workflow/wit/gen/testing_fibo-workflow-obelisk-schedule/testing_fibo-workflow-obelisk-schedule.wit

@@ -1,9 +1,9 @@
-// Generated by Obelisk 0.35.4
+// Generated by Obelisk 0.39.5
 package testing:fibo-workflow-obelisk-schedule;
 
 interface workflow {
-  use obelisk:types/execution@4.2.0.{execution-id};
-  use obelisk:types/time@4.2.0.{schedule-at};
+  use obelisk:types/execution@5.0.0.{execution-id};
+  use obelisk:types/time@5.0.0.{schedule-at};
 
   fibow-schedule: func(schedule-at: schedule-at, n: u8, iterations: u32) -> execution-id;