style: Fix clippy

Author: tomasol

crates/testing/test-utils/src/lib.rs

@@ -92,6 +92,7 @@ pub fn env_or_default<T: FromStr>(env_var: &str, default: T) -> T {
         .unwrap_or(default)
 }
 
+#[must_use]
 pub fn get_seed() -> Box<dyn Iterator<Item = u64>> {
     match std::env::var("TEST_SEED") {
         Ok(seed) => Box::new(std::iter::once(seed.parse().unwrap())),
@@ -102,9 +103,8 @@ pub fn get_seed() -> Box<dyn Iterator<Item = u64>> {
                 let seed = StdRng::from_entropy().r#gen();
                 vec.push(seed);
             }
-            Box::new(vec.into_iter().map(|seed| {
+            Box::new(vec.into_iter().inspect(|&seed| {
                 println!("TEST_SEED={seed}");
-                seed
             }))
         }
         _ => unreachable!(),

crates/wasm-workers/src/workflow/workflow_ctx.rs

@@ -1160,7 +1160,6 @@ pub(crate) mod tests {
     };
     use rand::SeedableRng as _;
     use rand::rngs::StdRng;
-    use std::u32;
     use std::{fmt::Debug, sync::Arc, time::Duration};
     use test_utils::get_seed;
     use test_utils::{arbitrary::UnstructuredHolder, sim_clock::SimClock};
@@ -1516,18 +1515,6 @@ pub(crate) mod tests {
             }
             let execution_log2 = db_connection.get(&execution_id).await.unwrap();
             println!("{execution_log2:?}");
-
-            fn skip_locked<'a>(
-                events_iter: impl Iterator<Item = &'a ExecutionEvent>,
-            ) -> impl Iterator<Item = &'a ExecutionEventInner> {
-                events_iter.filter_map(|event| {
-                    if matches!(event.event, ExecutionEventInner::Locked { .. }) {
-                        None
-                    } else {
-                        Some(&event.event)
-                    }
-                })
-            }
             assert_eq!(
                 skip_locked(execution_log.events.iter()).count(),
                 skip_locked(execution_log2.events.iter()).count()
@@ -2042,4 +2029,16 @@ pub(crate) mod tests {
         let child_res = child_log.into_finished_result().unwrap();
         assert_matches!(child_res, Ok(SupportedFunctionReturnValue::None));
     }
+
+    fn skip_locked<'a>(
+        events_iter: impl Iterator<Item = &'a ExecutionEvent>,
+    ) -> impl Iterator<Item = &'a ExecutionEventInner> {
+        events_iter.filter_map(|event| {
+            if matches!(event.event, ExecutionEventInner::Locked { .. }) {
+                None
+            } else {
+                Some(&event.event)
+            }
+        })
+    }
 }