Commit 558b76c
Fix three synonym issues flagged in review
1. Duplicate synonyms: Remove label from exact_synonyms when it duplicates
the new label (86 rows in entity_attribute_location.tsv, e.g.
OBA:2040177 'ceramide amount' was listed in its own synonyms)
2. Auto-generated labels: For 6 rows with empty defined_class_name but
known entity_name + location_name + attribute_name=amount, set explicit
label (e.g. 'insulin amount in blood') and add level synonym
3. Missing synonym support: Add exact_synonyms data_list_var to
chemical_role_attribute.yaml and chemical_role_attribute_location.yaml
patterns, add exact_synonyms column to both TSV files, and populate
level synonyms for all rows (e.g. 'blood thyroid hormone level' for
OBA:VT0003351 'blood thyroid hormone amount'; 'thyroid hormone level'
for auto-generated OBA:1000972)
Agent-Logs-Url: https://github.com/obophenotype/bio-attribute-ontology/sessions/8946373c-0106-42da-b062-f4970fe1292a
Co-authored-by: aleixpuigb <94959119+aleixpuigb@users.noreply.github.com>1 parent b5cf45e commit 558b76c
5 files changed
Lines changed: 123 additions & 111 deletions
File tree
- src/patterns
- data/default
- dosdp-patterns
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
Lines changed: 11 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
0 commit comments