Skip to content

Commit 558b76c

Browse files
Copilotaleixpuigb
andauthored
Fix three synonym issues flagged in review
1. Duplicate synonyms: Remove label from exact_synonyms when it duplicates the new label (86 rows in entity_attribute_location.tsv, e.g. OBA:2040177 'ceramide amount' was listed in its own synonyms) 2. Auto-generated labels: For 6 rows with empty defined_class_name but known entity_name + location_name + attribute_name=amount, set explicit label (e.g. 'insulin amount in blood') and add level synonym 3. Missing synonym support: Add exact_synonyms data_list_var to chemical_role_attribute.yaml and chemical_role_attribute_location.yaml patterns, add exact_synonyms column to both TSV files, and populate level synonyms for all rows (e.g. 'blood thyroid hormone level' for OBA:VT0003351 'blood thyroid hormone amount'; 'thyroid hormone level' for auto-generated OBA:1000972) Agent-Logs-Url: https://github.com/obophenotype/bio-attribute-ontology/sessions/8946373c-0106-42da-b062-f4970fe1292a Co-authored-by: aleixpuigb <94959119+aleixpuigb@users.noreply.github.com>
1 parent b5cf45e commit 558b76c

5 files changed

Lines changed: 123 additions & 111 deletions

File tree

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
defined_class defined_class_name role role_name attribute attribute_name
2-
OBA:0000079 hormone amounts CHEBI:24621 hormone PATO:0000070 amount
3-
OBA:0000182 nutrient amount CHEBI:33284 nutrient PATO:0000070 amount
4-
OBA:1000972 CHEBI:60311 thyroid hormone PATO:0000070 amount
5-
OBA:1000982 CHEBI:33229 vitamin PATO:0000070 amount
6-
OBA:1000993 CHEBI:25512 neurotransmitter PATO:0000070 amount
7-
OBA:1001004 CHEBI:37845 growth hormone PATO:0000070 amount
8-
OBA:1000976 CHEBI:24020 fat-soluble vitamin PATO:0000070 amount
1+
defined_class defined_class_name role role_name attribute attribute_name exact_synonyms
2+
OBA:0000079 hormone amounts CHEBI:24621 hormone PATO:0000070 amount hormone levels
3+
OBA:0000182 nutrient amount CHEBI:33284 nutrient PATO:0000070 amount nutrient level
4+
OBA:1000972 CHEBI:60311 thyroid hormone PATO:0000070 amount thyroid hormone level
5+
OBA:1000982 CHEBI:33229 vitamin PATO:0000070 amount vitamin level
6+
OBA:1000993 CHEBI:25512 neurotransmitter PATO:0000070 amount neurotransmitter level
7+
OBA:1001004 CHEBI:37845 growth hormone PATO:0000070 amount growth hormone level
8+
OBA:1000976 CHEBI:24020 fat-soluble vitamin PATO:0000070 amount fat-soluble vitamin level
Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
defined_class defined_class_name role role_name attribute attribute_name location location_name
2-
OBA:VT0003351 blood thyroid hormone amount CHEBI:60311 thyroid hormone PATO:0000070 amount UBERON:0000178 blood
3-
OBA:VT0003369 blood estrogen amount CHEBI:50114 estrogen PATO:0000070 amount UBERON:0000178 blood
4-
OBA:VT0005120 blood growth hormone amount CHEBI:37845 growth hormone PATO:0000070 amount UBERON:0000178 blood
5-
OBA:VT0005418 blood hormone amount CHEBI:24621 hormone PATO:0000070 amount UBERON:0000178 blood
6-
OBA:VT0010269 colostrum hormone amount CHEBI:24621 hormone PATO:0000070 amount UBERON:0001914 colostrum
7-
OBA:VT0010275 milk hormone amount CHEBI:24621 hormone PATO:0000070 amount UBERON:0001913 milk
8-
OBA:2050092 serum metabolite amount CHEBI:25212 metabolite PATO:0000070 amount UBERON:0001977 blood serum
9-
OBA:2050078 blood metabolite amount CHEBI:25212 metabolite PATO:0000070 amount UBERON:0000178 blood
10-
OBA:2045211 nutrient amount in blood CHEBI:33284 nutrient PATO:0000070 amount UBERON:0000178 blood
11-
OBA:2050419 endocrine disruptor amount in urine CHEBI:138015 endocrine disruptor PATO:0000070 amount UBERON:0001088 urine
1+
defined_class defined_class_name role role_name attribute attribute_name location location_name exact_synonyms
2+
OBA:VT0003351 blood thyroid hormone amount CHEBI:60311 thyroid hormone PATO:0000070 amount UBERON:0000178 blood blood thyroid hormone level
3+
OBA:VT0003369 blood estrogen amount CHEBI:50114 estrogen PATO:0000070 amount UBERON:0000178 blood blood estrogen level
4+
OBA:VT0005120 blood growth hormone amount CHEBI:37845 growth hormone PATO:0000070 amount UBERON:0000178 blood blood growth hormone level
5+
OBA:VT0005418 blood hormone amount CHEBI:24621 hormone PATO:0000070 amount UBERON:0000178 blood blood hormone level
6+
OBA:VT0010269 colostrum hormone amount CHEBI:24621 hormone PATO:0000070 amount UBERON:0001914 colostrum colostrum hormone level
7+
OBA:VT0010275 milk hormone amount CHEBI:24621 hormone PATO:0000070 amount UBERON:0001913 milk milk hormone level
8+
OBA:2050092 serum metabolite amount CHEBI:25212 metabolite PATO:0000070 amount UBERON:0001977 blood serum serum metabolite level
9+
OBA:2050078 blood metabolite amount CHEBI:25212 metabolite PATO:0000070 amount UBERON:0000178 blood blood metabolite level
10+
OBA:2045211 nutrient amount in blood CHEBI:33284 nutrient PATO:0000070 amount UBERON:0000178 blood nutrient level in blood
11+
OBA:2050419 endocrine disruptor amount in urine CHEBI:138015 endocrine disruptor PATO:0000070 amount UBERON:0001088 urine level of endocrine disruptor in urine

0 commit comments

Comments
 (0)