From 2a56f088a5c5a6a3f68da5b6968b7669ee60035d Mon Sep 17 00:00:00 2001 From: Milan Novota Date: Fri, 6 Mar 2026 02:13:18 +0100 Subject: [PATCH] Add post-action verification to finishing-a-development-branch and dispatching-parallel-agents finishing-a-development-branch Option 2 (Push + PR) had no confirmation that the push and PR creation actually succeeded. Added git log and gh pr view checks after the push/create sequence. dispatching-parallel-agents listed 'run full suite' as a bullet point in the Verification section but didn't mark it as a hard gate. Agents could return with conflicting changes and the skill gave no clear signal to stop if the suite failed. Made the requirement explicit with a blocking condition. --- skills/dispatching-parallel-agents/SKILL.md | 14 ++++++++++++-- skills/finishing-a-development-branch/SKILL.md | 8 ++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/skills/dispatching-parallel-agents/SKILL.md b/skills/dispatching-parallel-agents/SKILL.md index 33b14859f2..e386278968 100644 --- a/skills/dispatching-parallel-agents/SKILL.md +++ b/skills/dispatching-parallel-agents/SKILL.md @@ -164,12 +164,22 @@ Agent 3 → Fix tool-approval-race-conditions.test.ts ## Verification -After agents return: +After agents return, complete ALL steps before reporting done: + 1. **Review each summary** - Understand what changed 2. **Check for conflicts** - Did agents edit same code? -3. **Run full suite** - Verify all fixes work together +3. **Run full suite** - This is a hard gate, not optional + +```bash +npm test / cargo test / pytest / go test ./... +``` + +**If suite fails:** Stop. Do not report completion. Fix conflicts or re-dispatch the failing domain. + 4. **Spot check** - Agents can make systematic errors +**Never report integration complete without step 3 output in hand.** + ## Real-World Impact From debugging session (2025-10-03): diff --git a/skills/finishing-a-development-branch/SKILL.md b/skills/finishing-a-development-branch/SKILL.md index c308b43b4b..2587b6c71e 100644 --- a/skills/finishing-a-development-branch/SKILL.md +++ b/skills/finishing-a-development-branch/SKILL.md @@ -92,6 +92,9 @@ Then: Cleanup worktree (Step 5) # Push branch git push -u origin +# Verify push succeeded +git log origin/ -1 --oneline + # Create PR gh pr create --title "" --body "$(cat <<'EOF' ## Summary @@ -101,6 +104,9 @@ gh pr create --title "<title>" --body "$(cat <<'EOF' - [ ] <verification steps> EOF )" + +# Confirm PR was created +gh pr view --json url,title,state ``` Then: Cleanup worktree (Step 5) @@ -183,12 +189,14 @@ git worktree remove <worktree-path> - Merge without verifying tests on result - Delete work without confirmation - Force-push without explicit request +- Assume push/PR succeeded without checking **Always:** - Verify tests before offering options - Present exactly 4 options - Get typed confirmation for Option 4 - Clean up worktree for Options 1 & 4 only +- Confirm PR was created with `gh pr view` after Option 2 ## Integration