Skip to content

Commit 53f25b3

Browse files
Dylan MyersDylan-M
authored andcommitted
Address some of the feedback around the factories.
1 parent ead6ae3 commit 53f25b3

File tree

3 files changed

+5
-128
lines changed

3 files changed

+5
-128
lines changed

factories/exporters_aix.go

Lines changed: 2 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -25,45 +25,8 @@ import (
2525
"go.opentelemetry.io/collector/exporter/otlphttpexporter"
2626
)
2727

28-
// The following is a list of exporters removed because they use code or
29-
// libraries that are incompatible with AIX
30-
// awskinesisexporter.NewFactory(),
31-
// datadogexporter.NewFactory(),
32-
// kafkaexporter.NewFactory(),
33-
// logzioexporter.NewFactory(),
34-
// lokiexporter.NewFactory(),
35-
// opencensusexporter.NewFactory(),
36-
// prometheusexporter.NewFactory(),
37-
// prometheusremotewriteexporter.NewFactory(),
38-
// sapmexporter.NewFactory(),
39-
// sumologicexporter.NewFactory(),
40-
// zipkinexporter.NewFactory(),
41-
42-
// The following is a list of exporters removed because we are choosing
43-
// not to support them at this time; due to high effort to validate
44-
// alibabacloudlogserviceexporter.NewFactory(),
45-
// awscloudwatchlogsexporter.NewFactory(),
46-
// awsemfexporter.NewFactory(),
47-
// awss3exporter.NewFactory(),
48-
// awsxrayexporter.NewFactory(),
49-
// azureblobexporter.NewFactory(),
50-
// azuremonitorexporter.NewFactory(),
51-
// carbonexporter.NewFactory(),
52-
// chronicleexporter.NewFactory(),
53-
// chronicleforwarderexporter.NewFactory(),
54-
// clickhouseexporter.NewFactory(),
55-
// coralogixexporter.NewFactory(),
56-
// elasticsearchexporter.NewFactory(),
57-
// googlecloudexporter.NewFactory(version.Version()),
58-
// googlecloudpubsubexporter.NewFactory(),
59-
// googlemanagedprometheusexporter.NewFactory(version.Version()),
60-
// influxdbexporter.NewFactory(),
61-
// loadbalancingexporter.NewFactory(),
62-
// signalfxexporter.NewFactory(),
63-
// snowflakeexporter.NewFactory(),
64-
// splunkhecexporter.NewFactory(),
65-
// syslogexporter.NewFactory(),
66-
28+
// Restricted to a small subset of debugging exporters plus OTLP
29+
// Many exporters aren't compatible with AIX
6730
var defaultExporters = []exporter.Factory{
6831
fileexporter.NewFactory(),
6932
loggingexporter.NewFactory(),

factories/processors_aix.go

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -27,40 +27,10 @@ import (
2727
"go.opentelemetry.io/collector/processor/processortest"
2828
)
2929

30-
// The following is a list of processors removed because we are choosing
31-
// not to support them at this time; due to high effort to validate
32-
// cumulativetodeltaprocessor.NewFactory(),
33-
// datapointcountprocessor.NewFactory(),
34-
// deltatorateprocessor.NewFactory(),
35-
// groupbyattrsprocessor.NewFactory(),
36-
// k8sattributesprocessor.NewFactory(),
37-
// logcountprocessor.NewFactory(),
38-
// logdeduplicationprocessor.NewFactory(),
39-
// logstransformprocessor.NewFactory(),
40-
// lookupprocessor.NewFactory(),
41-
// maskprocessor.NewFactory(),
42-
// memorylimiterprocessor.NewFactory(),
43-
// metricextractprocessor.NewFactory(),
44-
// metricsgenerationprocessor.NewFactory(),
45-
// metricstatsprocessor.NewFactory(),
46-
// metricstransformprocessor.NewFactory(),
47-
// probabilisticsamplerprocessor.NewFactory(),
48-
// removeemptyvaluesprocessor.NewFactory(),
49-
// resourceattributetransposerprocessor.NewFactory(),
50-
// resourceprocessor.NewFactory(),
51-
// routingprocessor.NewFactory(),
52-
// samplingprocessor.NewFactory(),
53-
// snapshotprocessor.NewFactory(),
54-
// spancountprocessor.NewFactory(),
55-
// spanprocessor.NewFactory(),
56-
// throughputmeasurementprocessor.NewFactory(),
57-
// tailsamplingprocessor.NewFactory(),
58-
5930
var defaultProcessors = []processor.Factory{
6031
attributesprocessor.NewFactory(),
6132
batchprocessor.NewFactory(),
6233
processortest.NewNopFactory(),
63-
filterprocessor.NewFactory(),
6434
groupbytraceprocessor.NewFactory(),
6535
resourcedetectionprocessor.NewFactory(),
6636
transformprocessor.NewFactory(),

factories/receivers_aix.go

Lines changed: 3 additions & 59 deletions
Original file line numberDiff line numberDiff line change
@@ -44,62 +44,9 @@ import (
4444
"go.opentelemetry.io/collector/receiver/receivertest"
4545
)
4646

47-
// The following is a list of receivers removed because they use code or
48-
// libraries that are incompatible with AIX
49-
//jaegerreceiver.NewFactory(),
50-
//kafkareceiver.NewFactory(),
51-
//prometheusreceiver.NewFactory(),
52-
//sapmreceiver.NewFactory(),
53-
//simpleprometheusreceiver.NewFactory(),
54-
//zipkinreceiver.NewFactory(),
55-
56-
// The following is a list of receivers removed because we are choosing
57-
// not to support them at this time; due to high effort to validate
58-
// activedirectorydsreceiver.NewFactory(),
59-
// aerospikereceiver.NewFactory(),
60-
// apachereceiver.NewFactory(),
61-
// apachesparkreceiver.NewFactory(),
62-
// awscloudwatchreceiver.NewFactory(),
63-
// awscontainerinsightreceiver.NewFactory(),
64-
// awsecscontainermetricsreceiver.NewFactory(),
65-
// awsfirehosereceiver.NewFactory(),
66-
// awss3rehydrationreceiver.NewFactory(),
67-
// awsxrayreceiver.NewFactory(),
68-
// azureblobreceiver.NewFactory(),
69-
// azureblobrehydrationreceiver.NewFactory(),
70-
// azureeventhubreceiver.NewFactory(),
71-
// bigipreceiver.NewFactory(),
72-
// carbonreceiver.NewFactory(),
73-
// cloudflarereceiver.NewFactory(),
74-
// cloudfoundryreceiver.NewFactory(),
75-
// couchdbreceiver.NewFactory(),
76-
// dockerstatsreceiver.NewFactory(),
77-
// elasticsearchreceiver.NewFactory(),
78-
// flinkmetricsreceiver.NewFactory(),
79-
// googlecloudpubsubreceiver.NewFactory(),
80-
// googlecloudspannerreceiver.NewFactory(),
81-
// httpcheckreceiver.NewFactory(),
82-
// httpreceiver.NewFactory(),
83-
// iisreceiver.NewFactory(),
84-
// journaldreceiver.NewFactory(),
85-
// k8sclusterreceiver.NewFactory(),
86-
// k8seventsreceiver.NewFactory(),
87-
// kafkametricsreceiver.NewFactory(),
88-
// kubeletstatsreceiver.NewFactory(),
89-
// m365receiver.NewFactory(),
90-
// mongodbatlasreceiver.NewFactory(),
91-
// mongodbreceiver.NewFactory(),
92-
// podmanreceiver.NewFactory(),
93-
// redisreceiver.NewFactory(),
94-
// riakreceiver.NewFactory(),
95-
// routereceiver.NewFactory(),
96-
// splunkhecreceiver.NewFactory(),
97-
// telemetrygeneratorreceiver.NewFactory(),
98-
// vcenterreceiver.NewFactory(),
99-
// windowseventlogreceiver.NewFactory(),
100-
// windowsperfcountersreceiver.NewFactory(),
101-
// zookeeperreceiver.NewFactory(),
102-
47+
// Restricted list. Many receivers aren't supported on AIX.
48+
// Additionally, we're only including those that make sense for
49+
// An "unmanaged" config.
10350
var defaultReceivers = []receiver.Factory{
10451
collectdreceiver.NewFactory(),
10552
filelogreceiver.NewFactory(),
@@ -122,7 +69,4 @@ var defaultReceivers = []receiver.Factory{
12269
sqlqueryreceiver.NewFactory(),
12370
sqlserverreceiver.NewFactory(),
12471
statsdreceiver.NewFactory(),
125-
syslogreceiver.NewFactory(),
126-
tcplogreceiver.NewFactory(),
127-
udplogreceiver.NewFactory(),
12872
}

0 commit comments

Comments
 (0)