fix: S3 wrap PutObject into ReadSeeker - OB-51476 #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-justindaines
changed the title
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
obs-gh-justindaines
requested review from
a team,
obs-gh-alexlew and
obs-gh-mattcotter
obs-gh-justindaines
force-pushed
the
jdaines/s3-failed-to-rewind-transport-stream
branch
from
92237d4 to
be03e1d
Compare
obs-gh-justindaines
force-pushed
the
jdaines/s3-failed-to-rewind-transport-stream
branch
from
be03e1d to
b9c3737
Compare
| // This allows AWS SDK to retry S3 PutObject operations by rewinding the stream | ||
| var body io.ReadSeeker | ||
| if r != nil { | ||
| data, err := io.ReadAll(r) |
Contributor
There was a problem hiding this comment.
This is still my original concern, we should avoid reading things into memory entirely unless fully necessary. It leads to OOMs if the data is too large. Readers should be preferred unless absolutely necessary vs reading into memory being the default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix will resolve "failed to rewind transport stream for retry" errors during S3
PutObjectoperations.The AWS SDK retries failed
PutObjectrequests, but the original request body (io.Reader) was not seekable, causing rewind failures on retry.Fix:
Wrap the request body in a seekable io.ReadSeeker by reading it into memory first. This ensures retries can reset the stream position.