fix: Remove container information from pod metrics #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Container information currently is not reliable, a random container id / name is being discovered, which can lead to confusion. It should be possible to uniquely identify the container based on the pod, but I couldn't get this to work. That would still be the ideal solution - we can always add this back if we manage to get that to work. Fixes OB-45911
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
obs-gh-mattcotter
approved these changes
Jul 7, 2025
| - k8s.pod.name | ||
| - k8s.pod.uid | ||
| - k8s.cluster.uid | ||
| {{- if (ne .target "pod_metrics") }} |
Contributor
There was a problem hiding this comment.
this nested NE condition is a little tough to understand, can we add a comment here to explain what happens in the cases
- Not
pod_metrics or cluster_metrics pod_metricscluster_metrics
Collaborator
Author
There was a problem hiding this comment.
Yeah good callout. I add a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container information currently is not reliable, a random container id / name is being discovered, which can lead to confusion at best and labels/attributes dimensionality explosion at worst.
It should be possible to uniquely identify the container based on the pod, but I couldn't get this to work. That would still be the ideal solution - we can always add this back if we manage to get that to work. For now, better to remove the information completely.
Fixes OB-45911