Skip to content

added extra pipeline for metrics monitoring #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2025
Merged

added extra pipeline for metrics monitoring #416

merged 2 commits into from
Nov 18, 2025

Conversation

@obs-gh-virjramakrishnan
Copy link
Contributor

@obs-gh-virjramakrishnan obs-gh-virjramakrishnan commented Sep 4, 2025 •
edited
Loading

No description provided.

orca-security-us[bot]
orca-security-us bot reviewed Sep 4, 2025
View reviewed changes
Copy link

@orca-security-us orca-security-us bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@obs-gh-virjramakrishnan obs-gh-virjramakrishnan force-pushed the viraj/test-fargate branch 8 times, most recently from 13be99d to e298a0a Compare September 30, 2025 23:54
@obs-gh-virjramakrishnan obs-gh-virjramakrishnan marked this pull request as ready for review September 30, 2025 23:57
obs-gh-mattcotter
obs-gh-mattcotter reviewed Oct 1, 2025
View reviewed changes
@obs-gh-virjramakrishnan obs-gh-virjramakrishnan force-pushed the viraj/test-fargate branch 2 times, most recently from 8691d49 to 61e4888 Compare October 2, 2025 23:42
obs-gh-mattcotter
obs-gh-mattcotter reviewed Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@obs-gh-mattcotter obs-gh-mattcotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A couple small comments, then please also:

@obs-gh-virjramakrishnan obs-gh-virjramakrishnan force-pushed the viraj/test-fargate branch 4 times, most recently from 37e1267 to 5a9c3fa Compare November 11, 2025 01:41
obs-gh-mattcotter
obs-gh-mattcotter reviewed Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@obs-gh-mattcotter obs-gh-mattcotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left a few small comments, but lgtm! Do you have an associated docs change with instructions?

CC @obs-gh-alexlew for an extra pair of eyes while I'm traveling.

@obs-gh-virjramakrishnan
Copy link
Contributor Author

obs-gh-virjramakrishnan commented Nov 12, 2025

Addressed comments in the most recent push. I will work on the docs PR right now!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025 •
edited
Loading

The following chart updates are necessary:

diff --git a/charts/agent/Chart.yaml b/charts/agent/Chart.yaml
index 0b9be95..f5f7a1b 100644
--- a/charts/agent/Chart.yaml
+++ b/charts/agent/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: agent
 description: Chart to install K8s collection stack based on Observe Agent
 type: application
-version: 0.75.0
+version: 0.74.4
 appVersion: "2.10.1"
 dependencies:
   - name: opentelemetry-collector

@obs-gh-virjramakrishnan obs-gh-virjramakrishnan force-pushed the viraj/test-fargate branch 3 times, most recently from e447fc8 to 0e14c22 Compare November 14, 2025 01:50
@obs-gh-virjramakrishnan
Copy link
Contributor Author

obs-gh-virjramakrishnan commented Nov 14, 2025 •
edited
Loading

I did some restructuring of the config values because of some feedback: let me know if you like this structure: for the values that will determine how fargate works.

nodeless:
  enabled: false
  hostingPlatform: ""
  metrics:
    enabled: false

docs PR is here.

obs-gh-mattcotter
obs-gh-mattcotter approved these changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@obs-gh-mattcotter obs-gh-mattcotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a couple other small things, but looks great!

@obs-gh-virjramakrishnan obs-gh-virjramakrishnan force-pushed the viraj/test-fargate branch 2 times, most recently from 59af6a8 to 267684a Compare November 14, 2025 22:37
obs-gh-mattcotter
obs-gh-mattcotter approved these changes Nov 17, 2025
View reviewed changes
Copy link
Collaborator

@obs-gh-mattcotter obs-gh-mattcotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@obs-gh-virjramakrishnan obs-gh-virjramakrishnan enabled auto-merge (squash) November 18, 2025 22:55
@obs-gh-virjramakrishnan
add extra pipeline for kubeletstats monitoring in fargate pods
3b1b3a7
@obs-gh-virjramakrishnan
feat: OB-41415 send sidecar metrics to observe directly and restructu…
8a5e1fb 
…re config for extensibility

Customers have been requesting that we support EKS fargate hosted clusters.
To do this, I add a new fargate mode (off my default) that will install an
otel operator, which will use a sidecar container to query metrics from the
pod it is attached to.
@obs-gh-virjramakrishnan obs-gh-virjramakrishnan merged commit 24e95f1 into main Nov 18, 2025
12 checks passed
@obs-gh-virjramakrishnan obs-gh-virjramakrishnan deleted the viraj/test-fargate branch November 18, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orca-security-us orca-security-us[bot] orca-security-us[bot] left review comments

@obs-gh-mattcotter obs-gh-mattcotter obs-gh-mattcotter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@obs-gh-virjramakrishnan @obs-gh-mattcotter