Merge pull request #3135 from ilandikov/fix-render-markdown-list-items

fix: render markdown formatting in list items

Author: claremacrae

src/Renderer/QueryResultsRenderer.ts

@@ -28,6 +28,15 @@ export interface QueryRendererParameters {
     editTaskPencilClickHandler: EditButtonClickHandler;
 }
 
+function findClosestParentTask(listItem: ListItem) {
+    // Try to find the closest parent that is a task
+    let closestParentTask = listItem.parent;
+    while (closestParentTask !== null && !(closestParentTask instanceof Task)) {
+        closestParentTask = closestParentTask.parent;
+    }
+    return closestParentTask;
+}
+
 export class QueryResultsRenderer {
     /**
      * The complete text in the instruction block, such as:
@@ -257,12 +266,7 @@ export class QueryResultsRenderer {
     }
 
     private willBeRenderedLater(task: ListItem, renderedTasks: Set<ListItem>, tasks: ListItem[]) {
-        // Try to find the closest parent that is a task
-        let closestParentTask = task.parent;
-        while (closestParentTask !== null && !(closestParentTask instanceof Task)) {
-            closestParentTask = closestParentTask.parent;
-        }
-
+        const closestParentTask = findClosestParentTask(task);
         if (!closestParentTask) {
             return false;
         }
@@ -327,12 +331,20 @@ export class QueryResultsRenderer {
             return await this.addTask(taskList, taskLineRenderer, task, taskIndex, queryRendererParameters);
         }
 
-        return this.addListItem(taskList, task);
+        return await this.addListItem(taskList, task);
     }
 
-    private addListItem(taskList: HTMLUListElement, listItem: ListItem) {
+    private async addListItem(taskList: HTMLUListElement, listItem: ListItem) {
         const li = createAndAppendElement('li', taskList);
-        li.textContent = listItem.description;
+
+        const span = createAndAppendElement('span', li);
+        await this.textRenderer(
+            listItem.description,
+            span,
+            findClosestParentTask(listItem)?.path ?? '',
+            this.obsidianComponent,
+        );
+
         return li;
     }
 

tests/Renderer/QueryResultsRenderer.test.QueryResultsRenderer_tests_parent-child_items.approved.html

@@ -60,7 +60,7 @@
                 <a class="tasks-edit" title="Edit task" href="#"></a>
               </span>
               <ul class="contains-task-list plugin-tasks-query-result tasks-layout-hide-urgency">
-                <li>list item grand grand child</li>
+                <li><span>list item grand grand child</span></li>
               </ul>
             </li>
           </ul>
@@ -86,7 +86,7 @@
           </span>
           <ul class="contains-task-list plugin-tasks-query-result tasks-layout-hide-urgency">
             <li>
-              non task grandchild
+              <span>non task grandchild</span>
               <ul class="contains-task-list plugin-tasks-query-result tasks-layout-hide-urgency">
                 <li
                   class="task-list-item plugin-tasks-list-item"

tests/Renderer/QueryResultsRenderer.test.QueryResultsRenderer_tests_parent-child_items_reverse_sorted.approved.html

@@ -80,7 +80,7 @@
                 <a class="tasks-edit" title="Edit task" href="#"></a>
               </span>
               <ul class="contains-task-list plugin-tasks-query-result tasks-layout-hide-urgency">
-                <li>list item grand grand child</li>
+                <li><span>list item grand grand child</span></li>
               </ul>
             </li>
           </ul>
@@ -106,7 +106,7 @@
           </span>
           <ul class="contains-task-list plugin-tasks-query-result tasks-layout-hide-urgency">
             <li>
-              non task grandchild
+              <span>non task grandchild</span>
               <ul class="contains-task-list plugin-tasks-query-result tasks-layout-hide-urgency">
                 <li
                   class="task-list-item plugin-tasks-list-item"