tests: fix tests

Author: ramarivera

src/Renderer/TaskLineRenderer.ts

@@ -1,5 +1,5 @@
 import type { Moment } from 'moment';
-import { App, Component, MarkdownRenderer } from 'obsidian';
+import { type App, Component, MarkdownRenderer } from 'obsidian';
 import { GlobalFilter } from '../Config/GlobalFilter';
 import { TASK_FORMATS, getSettings } from '../Config/Settings';
 import type { QueryLayoutOptions } from '../Layout/QueryLayoutOptions';

tests/Renderer/QueryResultsRenderer.test.ts

@@ -3,6 +3,7 @@
  */
 import moment from 'moment';
 import type { Task } from 'Task/Task';
+import type { App } from 'obsidian';
 import { GlobalFilter } from '../../src/Config/GlobalFilter';
 import { State } from '../../src/Obsidian/Cache';
 import { QueryResultsRenderer } from '../../src/Renderer/QueryResultsRenderer';
@@ -32,13 +33,21 @@ afterEach(() => {
     resetSettings();
 });
 
+/**
+ * Since we don't use the app object's method or properties directly,
+ * and just treat it as an "opaque object" for markdown rendering, there is
+ * not a lot to mock in particular.
+ */
+const mockApp = {} as unknown as App;
+
 function makeQueryResultsRenderer(source: string, tasksFile: TasksFile) {
     return new QueryResultsRenderer(
         'block-language-tasks',
         source,
         tasksFile,
         () => Promise.resolve(),
         null,
+        mockApp,
         mockHTMLRenderer,
     );
 }

tests/Renderer/RenderingTestHelpers.ts

@@ -1,11 +1,13 @@
-export const mockHTMLRenderer = async (text: string, element: HTMLSpanElement, _path: string) => {
+import type { App } from 'obsidian';
+
+export const mockHTMLRenderer = async (_obsidianApp: App, text: string, element: HTMLSpanElement, _path: string) => {
     // Contrary to the default mockTextRenderer(),
     // instead of the rendered HTMLSpanElement.innerText,
     // we need the plain HTML here like in TaskLineRenderer.renderComponentText(),
     // to ensure that description and tags are retained.
     element.innerHTML = text;
 };
 
-export const mockTextRenderer = async (text: string, element: HTMLSpanElement, _path: string) => {
+export const mockTextRenderer = async (_obsidianApp: App, text: string, element: HTMLSpanElement, _path: string) => {
     element.innerText = text;
 };

tests/Renderer/TaskLineRenderer.test.ts

@@ -3,6 +3,7 @@
  */
 import moment from 'moment';
 
+import type { App } from 'obsidian';
 import { DebugSettings } from '../../src/Config/DebugSettings';
 import { GlobalFilter } from '../../src/Config/GlobalFilter';
 import { resetSettings, updateSettings } from '../../src/Config/Settings';
@@ -22,6 +23,13 @@ import { mockHTMLRenderer, mockTextRenderer } from './RenderingTestHelpers';
 jest.mock('obsidian');
 window.moment = moment;
 
+/**
+ * Since we don't use the app object's method or properties directly,
+ * and just treat it as an "opaque object" for markdown rendering, there is
+ * not a lot to mock in particular.
+ */
+const mockApp = {} as unknown as App;
+
 /**
  * Renders a task for test purposes and returns the rendered ListItem.
  *
@@ -41,6 +49,7 @@ async function renderListItem(
 ) {
     const taskLineRenderer = new TaskLineRenderer({
         textRenderer: testRenderer ?? mockTextRenderer,
+        obsidianApp: mockApp,
         obsidianComponent: null,
         parentUlElement: document.createElement('div'),
         taskLayoutOptions: taskLayoutOptions ?? new TaskLayoutOptions(),
@@ -84,6 +93,7 @@ describe('task line rendering - HTML', () => {
         const ulElement = document.createElement('ul');
         const taskLineRenderer = new TaskLineRenderer({
             textRenderer: mockTextRenderer,
+            obsidianApp: mockApp,
             obsidianComponent: null,
             parentUlElement: ulElement,
             taskLayoutOptions: new TaskLayoutOptions(),