Merge pull request #3557 from obsidian-tasks-group/rename-isLinkTo

refactor: Rename `Link.isLinkTo()` to `Link.linksTo()`

Author: claremacrae

resources/sample_vaults/Tasks-Demo/How To/Access links.md

@@ -104,12 +104,12 @@ This should match one task, in [[Link to Access links file]].
 
 ````text
 ```tasks
-filter by function task.outlinks.some(link => link.isLinkTo(query.file))
+filter by function task.outlinks.some(link => link.linksTo(query.file))
 ```
 ````
 
 ```tasks
-filter by function task.outlinks.some(link => link.isLinkTo(query.file))
+filter by function task.outlinks.some(link => link.linksTo(query.file))
 ```
 
 #### Dataview version

src/Task/Link.ts

@@ -76,7 +76,7 @@ export class Link {
         return this.rawLink.displayText;
     }
 
-    public isLinkTo(destination: string | TasksFile): boolean {
+    public linksTo(destination: string | TasksFile): boolean {
         if (typeof destination === 'string') {
             const removeMd = /\.md$/;
             const thisDestinationWithoutMd = this.destination.replace(removeMd, '');

tests/Task/Link.test.ts

@@ -32,8 +32,8 @@ describe('linkClass', () => {
         expect(link.destination).toEqual('link_in_file_body');
         expect(link.displayText).toEqual('link_in_file_body');
         expect(link.markdown).toEqual(link.originalMarkdown);
-        expect(link.isLinkTo('link_in_file_body')).toEqual(true);
-        expect(link.isLinkTo('link_in_file_body.md')).toEqual(true);
+        expect(link.linksTo('link_in_file_body')).toEqual(true);
+        expect(link.linksTo('link_in_file_body.md')).toEqual(true);
     });
 
     describe('getLink() configures Link.destinationPath automatically', () => {
@@ -286,43 +286,43 @@ describe('linkClass', () => {
         });
     });
 
-    describe('isLinkTo() tests', () => {
+    describe('linksTo() tests', () => {
         it('matches filenames', () => {
             const link = getLink(links_everywhere, 0);
 
-            expect(link.isLinkTo('link_in_file_body')).toEqual(true);
-            expect(link.isLinkTo('link_in_file_body.md')).toEqual(true);
+            expect(link.linksTo('link_in_file_body')).toEqual(true);
+            expect(link.linksTo('link_in_file_body.md')).toEqual(true);
 
-            expect(link.isLinkTo('somewhere_else')).toEqual(false);
+            expect(link.linksTo('somewhere_else')).toEqual(false);
 
-            expect(link.isLinkTo('link_in_file_body_but_different')).toEqual(false);
-            expect(link.isLinkTo('link_in_file_')).toEqual(false);
+            expect(link.linksTo('link_in_file_body_but_different')).toEqual(false);
+            expect(link.linksTo('link_in_file_')).toEqual(false);
         });
 
         it('matches without folders', () => {
             const linkToAFile = getLink(link_in_task_wikilink, 0);
             expect(linkToAFile.originalMarkdown).toMatchInlineSnapshot('"[[link_in_task_wikilink]]"');
 
-            expect(linkToAFile.isLinkTo('link_in_task_wikilink')).toEqual(true);
+            expect(linkToAFile.linksTo('link_in_task_wikilink')).toEqual(true);
         });
 
         it('matches with folders', () => {
             const linkToAFolder = getLink(link_in_task_wikilink, 2);
             expect(linkToAFolder.originalMarkdown).toMatchInlineSnapshot('"[[Test Data/link_in_task_wikilink]]"');
 
-            expect(linkToAFolder.isLinkTo('link_in_task_wikilink')).toEqual(true);
-            expect(linkToAFolder.isLinkTo('Test Data/link_in_task_wikilink')).toEqual(true);
-            expect(linkToAFolder.isLinkTo('Test Data/link_in_task_wikilink.md')).toEqual(true);
+            expect(linkToAFolder.linksTo('link_in_task_wikilink')).toEqual(true);
+            expect(linkToAFolder.linksTo('Test Data/link_in_task_wikilink')).toEqual(true);
+            expect(linkToAFolder.linksTo('Test Data/link_in_task_wikilink.md')).toEqual(true);
         });
 
         it('matches TasksFile - only exact paths match', () => {
             const linkToAFolder = getLink(link_in_task_wikilink, 2);
             expect(linkToAFolder.originalMarkdown).toMatchInlineSnapshot('"[[Test Data/link_in_task_wikilink]]"');
 
-            expect(linkToAFolder.isLinkTo(new TasksFile('Test Data/link_in_task_wikilink.md'))).toEqual(true);
-            expect(linkToAFolder.isLinkTo(new TasksFile('link_in_task_wikilink.md'))).toEqual(false);
-            expect(linkToAFolder.isLinkTo(new TasksFile('Wrong Test Data/link_in_task_wikilink.md'))).toEqual(false);
-            expect(linkToAFolder.isLinkTo(new TasksFile('something_obviously_different.md'))).toEqual(false);
+            expect(linkToAFolder.linksTo(new TasksFile('Test Data/link_in_task_wikilink.md'))).toEqual(true);
+            expect(linkToAFolder.linksTo(new TasksFile('link_in_task_wikilink.md'))).toEqual(false);
+            expect(linkToAFolder.linksTo(new TasksFile('Wrong Test Data/link_in_task_wikilink.md'))).toEqual(false);
+            expect(linkToAFolder.linksTo(new TasksFile('something_obviously_different.md'))).toEqual(false);
         });
     });
 });