fix: - results are filtered correctly after any edits to tasks or settings

Author: ilandikov

src/Renderer/QueryResultsRenderer.ts

@@ -158,14 +158,14 @@ export class QueryResultsRenderer {
     public async render(state: State, tasks: Task[], content: HTMLDivElement) {
         this.performSearch(tasks);
         this.addToolbar(content);
-        await this.renderQueryResult(state, this.queryResult, content);
+        await this.renderQueryResult(state, this.filteredQueryResult, content);
     }
 
     private performSearch(tasks: Task[]) {
         const measureSearch = new PerformanceTracker(`Search: ${this.query.queryId} - ${this.filePath}`);
         measureSearch.start();
         this.queryResult = this.query.applyQueryToTasks(tasks);
-        this.filteredQueryResult = this.queryResult;
+        this.filterResults();
         measureSearch.finish();
     }
 

tests/Renderer/QueryResultsRenderer.test.QueryResultsRenderer_-_sequences_rerendered_results_retain_the_filter.approved.html

@@ -148,27 +148,6 @@ <h2>Filtered results after editing Global Query:</h2>
         <a class="tasks-postpone" title="ℹ️ Due tomorrow, on Tue 2nd Dec (right-click for more options)"></a>
       </span>
     </li>
-    <li
-      class="task-list-item plugin-tasks-list-item"
-      data-task-priority="normal"
-      data-task=""
-      data-line="1"
-      data-task-status-name="Todo"
-      data-task-status-type="TODO">
-      <input class="task-list-item-checkbox" type="checkbox" data-line="1" />
-      <span class="tasks-list-text">
-        <span class="task-description"><span>child</span></span>
-        <span class="task-id"><span>🆔 childID</span></span>
-      </span>
-      <span class="task-extras">
-        <span class="tasks-backlink">
-          (
-          <a rel="noopener" target="_blank" class="internal-link">/</a>
-          )
-        </span>
-        <a class="tasks-edit" title="Edit task" href="#"></a>
-      </span>
-    </li>
   </ul>
-  <div class="task-count">2 tasks</div>
+  <div class="task-count">1 task</div>
 </div>

tests/Renderer/QueryResultsRenderer.test.ts

@@ -256,7 +256,6 @@ describe('QueryResultsRenderer - sequences', () => {
         GlobalQuery.getInstance().set('sort by function reverse task.description.length');
         storyboard.renderer.rereadQueryFromFile();
 
-        // The following renders two tasks, not one because the filter is lost
         await storyboard.renderAndAddFrame('Filtered results after editing Global Query');
 
         storyboard.verify();